◐ Shell
reader mode source ↗
Skip to content

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree#112659

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:revert-deprecation
Dec 3, 2023
Merged

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree#112659
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:revert-deprecation

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 3, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 3, 2023
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Dec 3, 2023
@iritkatriel @AlexWaygood
Update Doc/whatsnew/3.12.rst …
efd0846 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
serhiy-storchaka
serhiy-storchaka approved these changes Dec 3, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

onexc also can be deprecated soon. I am planning to add an error handler with different interface.

@iritkatriel iritkatriel merged commit 97857ac into python:main Dec 3, 2023
@miss-islington-app

miss-islington-app Bot commented Dec 3, 2023

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Dec 3, 2023

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 97857ac0580057c3a4f75d34209841c81ee11a96 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Dec 3, 2023
@iritkatriel
pythongh-112645: remove deprecation warning for use of onerror in shu… …
dcd1eac 
…til.rmtree (python#112659)

(cherry picked from commit 97857ac)
@bedevere-app

bedevere-app Bot commented Dec 3, 2023

Copy link
Copy Markdown

GH-112665 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 3, 2023
iritkatriel added a commit that referenced this pull request Dec 3, 2023
@iritkatriel
[3.12] gh-112645: remove deprecation warning for use of onerror in sh… …
f5965c2 
…util.rmtree (#112659) (#112665)

gh-112645: remove deprecation warning for use of onerror in shutil.rmtree (#112659)

(cherry picked from commit 97857ac)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112645: remove deprecation warning for use of onerror in shu… …
1184fe3 
…til.rmtree (python#112659)
@AlexWaygood AlexWaygood mentioned this pull request Jun 6, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112645: remove deprecation warning for use of onerror in shu… …
b898072 
…til.rmtree (python#112659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@iritkatriel iritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undeprecate the onerror argument in shutil.rmtree()

3 participants

@iritkatriel @serhiy-storchaka @AlexWaygood