◐ Shell
reader mode source ↗
Skip to content

gh-111545: Add Py_HashDouble() function#113115

Closed
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:hash_double4
Closed

gh-111545: Add Py_HashDouble() function#113115
vstinner wants to merge 2 commits into
python:mainfrom
vstinner:hash_double4

Conversation

@vstinner

@vstinner vstinner commented Dec 14, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Add tests: Modules/_testcapi/hash.c and
Lib/test/test_capi/test_hash.py.

📚 Documentation preview 📚: https://cpython-previews--113115.org.readthedocs.build/

@vstinner
pythongh-111545: Add Py_HashDouble() function …
9b00e3e 
Add tests: Modules/_testcapi/hash.c and
Lib/test/test_capi/test_hash.py.
@vstinner vstinner requested a review from tiran as a code owner December 14, 2023 14:48
@bedevere-app bedevere-app Bot mentioned this pull request Dec 14, 2023
Closed
@vstinner vstinner mentioned this pull request Dec 14, 2023
Closed
@vstinner vstinner mentioned this pull request Dec 16, 2023
Closed
4 tasks
@vstinner

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

I created PR #112095 more than 1 month ago. I spent time to run benchmark, implement different APIs, try to collect feedback on each API, and discuss in length advantages and disadvantages of each API. Sadly, we failed to reach a consensus on the API. Now another API is being discussed. The API looks simple to me, I didn't expect to spend more than one month on a single function.

I need to take a break from that topic. I don't have the energy to dig into these discussions. I prefer to close the PR for now.

@vstinner vstinner closed this Dec 20, 2023
@vstinner vstinner deleted the hash_double4 branch December 20, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @serhiy-storchaka