gh-58211: Add tests for self attribute of builtins functions#113575

adorilson

Although there was an inconclusive discussion in #58211, this PR adds tests to __self__ in built-in callables as it work currently.

If was accepted, after PR #113574 is merged we can fix the documentation too (just avoid conflict).

Issue: __self__ on built-in functions is not as documented #58211

The check about the f argument type was removed in this commit: python@2c94aa5 Thanks for Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) by the help with this bug.

…#106335) Remove private _PyThreadState and _PyInterpreterState C API functions: move them to the internal C API (pycore_pystate.h and pycore_interp.h). Don't export most of these functions anymore, but still export functions used by tests. Remove _PyThreadState_Prealloc() and _PyThreadState_Init() from the C API, but keep it in the stable API.

AlexWaygood

This appears to me to go in the opposite direction to the consensus in #58211 -- the consensus seems to me to be that this is a misfeature that could only be confusing. That doesn't mean that we should necessarily bother changing the current behaviour unless it's actually causing a bug for somebody. But we should only add tests for things which are working in a desirable way currently -- we shouldn't cement undesirable behaviour by adding tests for it.

I'm therefore doubtful that this PR is a good idea. Instead, as I suggested in #113574 (comment), I think we should fix the documentation so that it is more vague about what the value of this attribute might be for builtin functions.

adorilson

we shouldn't cement undesirable behaviour by adding tests for it.

Yes, I agree. (Although I'm the PR author). The big problem is where desirable behaviour is defined.
I found a PEP concern about this but didn't find it. Do you know if it exists?

Furthermore, ignoring other necessary knowledge, I think of the self as the member's owner. So, thinking about the module as the built-in functions' owner was natural.

I'm therefore doubtful that this PR is a good idea. Instead, as I suggested in #113574 (comment), I think we should fix the documentation so that it is more vague about what the value of this attribute might be for builtin functions.

I don't know if this is a good idea. I guess not.

Maybe it is better to remove this attribute from the documentation. Seeing the Terry's comment, the bug is not only the __self__ value but their own existence. In this sense, we already have been cementing undesirable behaviour.

serhiy-storchaka

There is a code in inspect or pydoc to work around this "feature". There may be a third-party code or even code in the stdlib that depends on this feature. If we even change this in future, it is better to have explicit tests that will fail, so this change will not pass unnoticed as a side effect of other changes. We can make these tests running only on CPython, and add comments explaining this.

adorilson

If we even change this in future, it is better to have explicit tests that will fail, so this change will not pass unnoticed as a side effect of other changes. We can make these tests running only on CPython, and add comments explaining this.

Do you mean:

Considering this PR
Keeping in documentation __self__ is set to None (because it is the desirable behaviour)
Adding in documentation a impl-detail directive: Currently, CPython returns the module object where the built-in function is defined, but it can change in the future.

?

serhiy-storchaka

I meant considering this PR.

AlexWaygood

@adorilson, if you make @serhiy-storchaka's suggested changes, then we can consider merging this:

We can make these tests running only on CPython, and add comments explaining this.

We have a test.support.cpython_only decorator for tests that are only meant to run if the implementation is CPython.

bedevere-app

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

adorilson

I have made the requested changes; please review again

I've added the test.support.cpython_only.

Regarding the comment explaining it, I put a 'See gh-58211' only. Is it enough?

bedevere-app

Thanks for making the requested changes!

@AlexWaygood: please review the changes made to this pull request.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

adorilson

I have made the requested changes; please review again

bedevere-app

Thanks for making the requested changes!

@AlexWaygood: please review the changes made to this pull request.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka

LGTM.

miss-islington-app

Thanks @adorilson for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…nctions (pythonGH-113575) --------- (cherry picked from commit 891465f) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app

GH-132437 is a backport of this pull request to the 3.13 branch.

…unctions (GH-113575) (#132437) gh-58211: Add tests for the `__self__` attribute of builtins functions (GH-113575) --------- (cherry picked from commit 891465f) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.13 (tier-2) has failed when building commit 70c4bd6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1512/builds/501) and take a look at the build logs.
Check if the failure is related to this commit (70c4bd6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1512/builds/501

Failed tests:

test_perf_profiler

Failed subtests:

test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_bpnjkkps/tmp0s3c50qt/perftest.py' not found in 'python 2200791 1629299.198245:          1 cycles:Pu: \n\t    ffffbe78fac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2200791 1629299.198284:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffbe78fac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2200791 1629299.199087:          1 cycles:Pu: \n\t    ffffbe77d7a8 _dl_lookup_symbol_x+0x88 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe7816ff resolve_map+0x79f (inlined)\n\t    ffffbe7816ff elf_machine_rela+0x79f (inlined)\n\t    ffffbe7816ff elf_dynamic_do_Rela+0x79f (inlined)\n\t    ffffbe7816ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78d3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78a5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78bb17 _dl_start_final+0x5ab (inlined)\n\t    ffffbe78bb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78fad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2200791 1629299.199112:        310 cycles:Pu: \n\t    ffffbe77cd7c do_lookup_x+0xfc (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe77d833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe7816ff resolve_map+0x79f (inlined)\n\t    ffffbe7816ff elf_machine_rela+0x79f (inlined)\n\t    ffffbe7816ff elf_dynamic_do_Rela+0x79f (inlined)\n\t    ffffbe7816ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78d3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78a5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78bb17 _dl_start_final+0x5ab (inlined)\n\t    ffffbe78bb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe78fad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\n
ld/python)\n\t          68b597 pymain_init+0x57 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b703 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b797 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffffbe52625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffbe52633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2200791 1629299.201163:      73859 cycles:Pu: \n\t    ffffbe7829c8 _dl_fixup+0x68 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffbe784ef7 _dl_runtime_resolve+0x47 (/usr/lib/ld-linux-aarch64.so.1)\n\t          678a5b _PyThread_cond_init+0x17 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          678a5b _PyThread_cond_init+0x17 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          629673 create_gil+0x37 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          629727 init_own_gil+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62a7bb _PyEval_InitGIL+0xe3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6531a7 init_interp_create_gil+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653443 pycore_create_interpreter+0x28f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653cf3 pyinit_config+0x6f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b3ab pyinit_core+0xdb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b483 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b63f pymain_init+0xff (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b703 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b797 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffffbe52625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffbe52633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2200791 1629299.201572:     590235 cycles:Pu: \n\t          57eb40 _PyUnicode_InitStaticStrings+0x85c0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e39f init_global_interned_strings+0x77 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e5e7 _PyUnicode_InitGlobalObjects+0x63 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6534af pycore_init_global_objects+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653a57 pycore_interp_init+0x2b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653d33 pyinit_config+0xaf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b3ab pyinit_core+0xdb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b483 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_gwnie6fm/tmpqdze5_a5/perftest.py' not found in 'python 2289302 1630209.314755:          1 cycles:Pu: \n\t    ffffa9cbfac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2289302 1630209.314787:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffa9cbfac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2289302 1630209.315112:          1 cycles:Pu: \n\t    ffffa9cc0f40 __fstat+0x0 (inlined)\n\t    ffffa9cae70f _dl_sysdep_read_whole_file+0x4f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cb6a0f _dl_load_cache_lookup+0x127 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cac2c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca75bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca6303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca7b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbd19f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cba5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbbb17 _dl_start_final+0x5ab (inlined)\n\t    ffffa9cbbb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbfad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2289302 1630209.315140:        292 cycles:Pu: \n\tffffaa282d37ff10 [unknown] ([unknown])\n\tffffaa282d3804cc [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffa9cc1628 __mmap64+0x28 (inlined)\n\t    ffffa9cc1628 mmap64+0x28 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cae75b _dl_sysdep_read_whole_file+0x9b (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cb6a0f _dl_load_cache_lookup+0x127 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cac2c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca75bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca6303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9ca7b33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbd19f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cba5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbbb17 _dl_start_final+0x5ab (inlined)\n\t    ffffa9cbbb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa9cbfad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2289302 1630209.316158:       1391 cycles:Pu: \n\t          50c52c mi_prim_open+0xc (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          50c573 unix_detect_overcommit+0x17 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51420b _mi_prim_mem_init+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51423f _mi_os_init+0x17 (/home/buildbot/buil
-aarch64.refleak/build/python)\n\t          68b55b pymain_init+0x1b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b703 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b797 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffffa9a5625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa9a5633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2289302 1630209.317230:     117970 cycles:Pu: \n\t    ffffa9ac080c __GI___pthread_mutex_unlock_usercnt+0x0 (/usr/lib64/libc.so.6)\n\t          629ee3 take_gil+0x237 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62a97f _PyEval_AcquireLock+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65f323 _PyThreadState_Attach+0x3f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          62a72f _PyEval_InitGIL+0x57 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6531a7 init_interp_create_gil+0x33 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653443 pycore_create_interpreter+0x28f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653cf3 pyinit_config+0x6f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b3ab pyinit_core+0xdb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b483 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b63f pymain_init+0xff (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b703 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b797 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffffa9a5625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa9a5633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2289302 1630209.318139:    1136025 cycles:Pu: \n\t          4ee8b8 _PyObject_GC_MAY_BE_TRACKED+0x0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f4f47 insert_to_emptydict+0x193 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f5c9b setitem_take2_lock_held+0x133 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f6223 _PyDict_SetItem_Take2+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f6283 PyDict_SetItem+0x57 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a3db add_tp_new_wrapper+0x67 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a467 type_ready_set_new+0x4b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5476ef type_ready+0x87 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          54788f init_static_type+0xab (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          547a6f _PyStaticType_InitBuiltin+0x23 (/home/buildbot/buildarea/3.13

adorilson and others added 3 commits December 29, 2023 19:34

Doc: Fix the array.fromfile method doc …

82958e3

The check about the f argument type was removed in this commit: python@2c94aa5 Thanks for Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) by the help with this bug.

Add builtin functions/methods __self__ test

e0a2693

bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Dec 29, 2023

bedevere-app Bot mentioned this pull request Dec 29, 2023

__self__ on built-in functions is not as documented #58211

Open

adorilson mentioned this pull request Jan 1, 2024

gh-111746: Doc: Format built-in function's attributes #113574

Open

AlexWaygood reviewed Jan 1, 2024

View reviewed changes

AlexWaygood requested a review from serhiy-storchaka January 1, 2024 15:25

serhiy-storchaka added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 2, 2024

serhiy-storchaka changed the title ~~gh-58211 Add builtins callables tests~~ Jan 2, 2024

serhiy-storchaka added needs backport to 3.13 bugs and security fixes and removed only security fixes labels May 9, 2024

AlexWaygood requested changes Jan 3, 2025

View reviewed changes

bedevere-app Bot removed the awaiting review label Jan 3, 2025

bedevere-app Bot added the awaiting changes label Jan 3, 2025

AlexWaygood and others added 2 commits January 3, 2025 14:25

Merge branch 'main' into gh-58211_add_bultins_functions_tests

3796829

pythongh-58211: Add tests for __self__ attribute of builtins functions

5eb85ff

bedevere-app Bot added awaiting change review and removed awaiting changes labels Mar 16, 2025

bedevere-app Bot requested a review from AlexWaygood March 16, 2025 17:57

skirpichev removed the needs backport to 3.12 only security fixes label Apr 10, 2025

Merge branch 'main' into gh-58211_add_bultins_functions_tests

df8226a

skirpichev approved these changes Apr 10, 2025

View reviewed changes

serhiy-storchaka reviewed Apr 10, 2025

View reviewed changes

adorilson and others added 4 commits April 10, 2025 21:57

pythongh-58211: Put full URL to GH issue …

c61e470

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

pythongh-58211: Put imports alphabetically sorted

0fcf92a

pythongh-58211: Use more strict assertions

0454ca4

pythongh-58211: Add test to builtin constants bound method

c032a85

adorilson requested review from picnixz, serhiy-storchaka and skirpichev April 10, 2025 22:50

skirpichev approved these changes Apr 11, 2025

View reviewed changes

serhiy-storchaka reviewed Apr 11, 2025

View reviewed changes

pythongh-58211: Remove redundant tests …

c7f959b

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka approved these changes Apr 11, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting change review labels Apr 11, 2025

Merge branch 'main' into gh-58211_add_bultins_functions_tests

9869caf

picnixz approved these changes Apr 12, 2025

View reviewed changes

picnixz enabled auto-merge (squash) April 12, 2025 11:39

picnixz merged commit 891465f into python:main Apr 12, 2025

bedevere-app Bot removed the awaiting merge label Apr 12, 2025

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 12, 2025

Conversation

adorilson commented Dec 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adorilson commented Jan 1, 2024

Uh oh!

serhiy-storchaka commented Jan 1, 2024

Uh oh!

adorilson commented Jan 1, 2024

Uh oh!

serhiy-storchaka commented Jan 2, 2024

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app Bot commented Jan 3, 2025

Uh oh!

adorilson commented Mar 16, 2025

Uh oh!

bedevere-app Bot commented Mar 16, 2025

Uh oh!

adorilson commented Apr 10, 2025

Uh oh!

bedevere-app Bot commented Apr 10, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Apr 12, 2025

Uh oh!

bedevere-app Bot commented Apr 12, 2025

Uh oh!

bedevere-bot commented Apr 12, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

adorilson commented Dec 29, 2023 •

edited

Loading

AlexWaygood left a comment •

edited

Loading