{{ message }}
gh-81094: Refer to PEP 318 in compound_statements.rst#113588
Merged
hugovk merged 5 commits intoJan 2, 2024
Merged
Conversation
…er Function definitions section.
Sorry, something went wrong.
hugovk
approved these changes
Dec 30, 2023
slateny
reviewed
Dec 31, 2023
Contributor
Author
|
I just did another pull request to fix the sentence. Let me know if you want me to do that other change. I am working tomorrow anyway.
I am eager to contribute, as I work with Machine Learning / AI stuff and business process automation, and so I have ideas about more advanced stuff to contribute (i.e., to things like openpyxl and python-pptx and natural language processing), but I realize I have to start with the easy stuff and then work my way up.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Saturday, December 30, 2023 at 10:49:35 PM CST, Stanley ***@***.***> wrote:
@slateny commented on this pull request.
In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
LGTM as well, thanks. Optionally, it might be useful to mirror the "Class definitions" section and also reference PEP 3129 under the "Function definitions" block with something like
⬇️ Suggested change- Function and method decorators were introduced.
+ Function and method decorators were introduced. Class decorators were introduced in :pep:`3129`.
I'll let Hugo decide whether that addition's useful or not 🙂
Since we're changing this section anyways, on line 1365 there's a missing period after variables and instance variables that my suggestion can't quite reach. If you could give that a quick fix, that'd be great too!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sorry, something went wrong.
…e_80914_Adding_PEP_318_Reference
b6b5be4 to
5c2ec84
Compare
December 31, 2023 20:22
Contributor
Author
|
Ok, I think (hope) I did this correctly. See below. Another reason for volunteering is I am hoping to improve my Github skills. Like I didn't even know you could do more than one commit per pull request.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Sunday, December 31, 2023 at 09:21:40 AM CST, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
Sure, let's include this.
@Rasputin2 Please could you add that? You can click the "Commit suggestion" button to apply this.
And add the period as a new commit in this PR, rather than a new one.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sorry, something went wrong.
hugovk
reviewed
Jan 1, 2024
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Contributor
Author
|
I believe I accepted these changes as part of the same PR. So, I think this is done, unless you guys disagree.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Monday, January 1, 2024 at 03:08:05 AM CST, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/reference/compound_stmts.rst:
:pep:`563` - Postponed Evaluation of Annotations
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
Please add this bit:
⬇️ Suggested change- Function and method decorators were introduced.
+ Function and method decorators were introduced.
+ Class decorators were introduced in :pep:`3129`.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sorry, something went wrong.
hugovk
approved these changes
Jan 2, 2024
hugovk
left a comment
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
|
Thanks @Rasputin2 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 2, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 2, 2024
hugovk
added a commit
that referenced
this pull request
Jan 2, 2024
hugovk
added a commit
that referenced
this pull request
Jan 2, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…13588) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…13588) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
…er Function definitions section.
📚 Documentation preview 📚: https://cpython-previews--113588.org.readthedocs.build/en/113588/reference/compound_stmts.html