◐ Shell
reader mode source ↗
Skip to content

gh-113602: Bail out when the parser tries to override existing errors#113607

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-113602
Jan 2, 2024
Merged

gh-113602: Bail out when the parser tries to override existing errors#113607
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-113602

Conversation

@pablogsal

@pablogsal pablogsal commented Dec 31, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 31, 2023
Closed
@pablogsal pablogsal added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 31, 2023
@pablogsal
pythongh-113602: Bail out when the parser tries to override existing … …
69a8d6b 
…errors

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
lysnikolaou
lysnikolaou approved these changes Jan 2, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

@pablogsal pablogsal merged commit 9ed36d5 into python:main Jan 2, 2024
@pablogsal pablogsal deleted the gh-113602 branch January 2, 2024 13:00
@miss-islington-app

miss-islington-app Bot commented Jan 2, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2024
@pablogsal @miss-islington
pythongh-113602: Bail out when the parser tries to override existing … …
08fabb1 
…errors (pythonGH-113607)

(cherry picked from commit 9ed36d5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app

bedevere-app Bot commented Jan 2, 2024

Copy link
Copy Markdown

GH-113652 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2024
@pablogsal @miss-islington
pythongh-113602: Bail out when the parser tries to override existing … …
9f76598 
…errors (pythonGH-113607)

(cherry picked from commit 9ed36d5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app

bedevere-app Bot commented Jan 2, 2024

Copy link
Copy Markdown

GH-113653 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 2, 2024
pablogsal added a commit that referenced this pull request Jan 2, 2024
@miss-islington @pablogsal
[3.11] gh-113602: Bail out when the parser tries to override existing… …
1c381ec 
… errors (GH-113607) (#113653)

gh-113602: Bail out when the parser tries to override existing errors (GH-113607)
(cherry picked from commit 9ed36d5)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jan 2, 2024
@miss-islington @pablogsal
[3.12] gh-113602: Bail out when the parser tries to override existing… …
499f1d0 
… errors (GH-113607) (#113652)

gh-113602: Bail out when the parser tries to override existing errors (GH-113607)
(cherry picked from commit 9ed36d5)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@pablogsal @kulikjak
pythongh-113602: Bail out when the parser tries to override existing … …
0ed43f5 
…errors (python#113607)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-113602: Bail out when the parser tries to override existing … …
ff72d10 
…errors (python#113607)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-113602: Bail out when the parser tries to override existing … …
d710185 
…errors (python#113607)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @lysnikolaou