{{ message }}
gh-101100: Fix Sphinx warnings for removed dead batteries#113669
Merged
hugovk merged 5 commits intoJan 3, 2024
Merged
Conversation
Member
Sorry, something went wrong.
hugovk
added
docs
Documentation in the Doc dir
skip news
needs backport to 3.12
only security fixes
labels
Jan 2, 2024
AlexWaygood
reviewed
Jan 3, 2024
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Looks good, just a couple of suggestions to fix some adjacent warnings while we're here:
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Member
Author
|
Thanks, these 10 also now fixed: Edit: include that extra one :) |
Sorry, something went wrong.
AlexWaygood
approved these changes
Jan 3, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
|
Sorry, @hugovk, I could not cleanly backport this to |
Sorry, something went wrong.
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Jan 3, 2024
pythonGH-113669) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit fab7ad6) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Jan 3, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…on#113669) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…on#113669) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…on#113669) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fix 58 warnings for modules removed by PEP 594: "Removing dead batteries from the standard library":
These removals began in 3.12, and the bulk were in 3.13. So some need backporting to 3.12, and we don't need to backport to 3.11.
📚 Documentation preview 📚: https://cpython-previews--113669.org.readthedocs.build/