◐ Shell
reader mode source ↗
Skip to content

gh-101100: fix sphinx warnings in reference/datamodel.rst#114280

Closed
skirpichev wants to merge 4 commits into
python:mainfrom
skirpichev:datamodel.rst-101100
Closed

gh-101100: fix sphinx warnings in reference/datamodel.rst#114280
skirpichev wants to merge 4 commits into
python:mainfrom
skirpichev:datamodel.rst-101100

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jan 19, 2024
Open
@skirpichev skirpichev mentioned this pull request Jan 19, 2024
Closed
@AlexWaygood AlexWaygood added docs Documentation in the Doc dir skip news labels Jan 19, 2024
@skirpichev skirpichev marked this pull request as draft January 19, 2024 07:48
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 19, 2024
@skirpichev @AlexWaygood
Update Doc/reference/datamodel.rst …
4adf825 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood

AlexWaygood commented Jan 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Suggestion: you may want to consider separate PRs for tackling warnings relating to module attributes and those relating to class attributes. Fixing the Sphinx nitpicks in the datamodel docs in a principled way is not trivial -- I've been picking away at them for a while, in #112737, #112781, #112735, #112832, #112933, etc. :)

Keeping the PRs small will make it easier for us to review your PRs, and make it easier for you to address our feedback.

I haven't as much time to work on it right now, so it's great some other people are getting involved!

@serhiy-storchaka

serhiy-storchaka commented Jan 19, 2024

Copy link
Copy Markdown
Member

Directive currentclass (similar to currentmodule) would help us.

@skirpichev skirpichev mentioned this pull request Jan 20, 2024
Closed
@skirpichev

skirpichev commented Jan 20, 2024

Copy link
Copy Markdown
Member Author

#114336 - is a set/frozenset issue.

@skirpichev skirpichev closed this Jan 27, 2024
@skirpichev skirpichev deleted the datamodel.rst-101100 branch January 27, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Assignees

No one assigned

Labels

docs needs backport to 3.11 needs backport to 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev @AlexWaygood @serhiy-storchaka @hugovk