gh-108303: Remove the non-test Lib/test/reperf.py#114356
Conversation
gpshead
left a comment
There was a problem hiding this comment.
apparently test_embed.py runs this code?
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
Ok, looks like it was used recently in #110769 by @ambv I propose to:
|
Sorry, something went wrong.
4752216 to
93da596
Compare
February 15, 2024 08:25
|
I am now using another file instead of So, we can remove the unneeded |
Sorry, something went wrong.
encukou
left a comment
There was a problem hiding this comment.
LGTM, but I'd rather not backport the removal.
Sorry, something went wrong.
|
@encukou looks like this PR #113601 influenced the CI. I fixed tests, so now both Please, take another look :) |
Sorry, something went wrong.
|
OK. Thanks! |
Sorry, something went wrong.
Looks like this file was not touched for at least 12 years: https://github.com/python/cpython/commits/main/Lib/test/reperf.py
It does not seem useful. If it is, I can instead move it to
Tool/scripts.Refs #114354