bpo-12707: deprecate info(), geturl(), getcode() methods in favor of headers, url, and status properties for HTTPResponse and addinfourl#11447
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
I think there is no consensus on the issue about raising code level deprecation as noted in https://bugs.python.org/issue12707#msg234945 and this causes a lot of tests to fail to |
Sorry, something went wrong.
|
@tirkarthi Makes sense, I've removed the deprecation code/notice for now. It feels odd though having multiple methods/properties that return the same thing; ideally all the duplicates should be deprecated. For now I've added the "recommended to use [x] instead" notice in the docs. |
Sorry, something went wrong.
Co-Authored-By: epicfaace <aramaswamis@gmail.com>
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
Sorry, something went wrong.
matrixise
left a comment
There was a problem hiding this comment.
Thank you for your contribution but could you update your PR with my remarks.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Sorry, something went wrong.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @merwok, @matrixise: please review the changes made to this pull request. |
Sorry, something went wrong.
matrixise
left a comment
There was a problem hiding this comment.
Thank you for your contribution
Sorry, something went wrong.
|
@epicfaace I have fixed the |
Sorry, something went wrong.
I have seen an error with the deprecated directive and I can't compile the doc on my laptop
|
Thank you so much for your contribution, I closed the issue and have merged this PR. |
Sorry, something went wrong.
|
This PR documented functions returning a status code as Please could someone review PR #101296 to fix it? |
Sorry, something went wrong.
https://bugs.python.org/issue12707