◐ Shell
reader mode source ↗
Skip to content

gh-103323: Remove current_fast_get() unused parameter#114593

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:current_fast_get
Jan 30, 2024
Merged

gh-103323: Remove current_fast_get() unused parameter#114593
vstinner merged 1 commit into
python:mainfrom
vstinner:current_fast_get

Conversation

@vstinner

@vstinner vstinner commented Jan 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.

@vstinner
pythongh-103323: Remove current_fast_get() unused parameter …
ddce5a1 
The current_fast_get() static inline function doesn't use its
'runtime' parameter, so just remove it.
@bedevere-app bedevere-app Bot mentioned this pull request Jan 26, 2024
Closed
@vstinner

vstinner commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

@ericsnowcurrently @colesbury @corona10: Would you mind to review this change?

The change commit f8abfa3 modified current_fast_get(). Before the Python Thread State was retrieved from runtime, but it's no longer the case.

ericsnowcurrently
ericsnowcurrently approved these changes Jan 26, 2024
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

IIRC, the main reason I left the parameter was to reduce churn. After that I didn't see any harm in leaving the parameter. That said, I'm not opposed to dropping it.

colesbury
colesbury approved these changes Jan 26, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks more straightforward to me too

corona10
corona10 approved these changes Jan 26, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

@vstinner vstinner merged commit 58f883b into python:main Jan 30, 2024
@vstinner vstinner deleted the current_fast_get branch January 30, 2024 10:48
@vstinner

vstinner commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-103323: Remove current_fast_get() unused parameter (python#1… …
b81e357 
…14593)

The current_fast_get() static inline function doesn't use its
'runtime' parameter, so just remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @colesbury @ericsnowcurrently @corona10