◐ Shell
reader mode source ↗
Skip to content

gh-108562: fix compiler warnings for bundled libmpdec in the main#114751

Merged
erlend-aasland merged 1 commit into
python:mainfrom
skirpichev:enable-strict-overflow-108562
Mar 3, 2024
Merged

gh-108562: fix compiler warnings for bundled libmpdec in the main#114751
erlend-aasland merged 1 commit into
python:mainfrom
skirpichev:enable-strict-overflow-108562

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 30, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This patch enable (if awailable) -fstrict-overflow for libmpdec and also shut off false positive warnings (-Warray-bounds). The later part was backported from mpdecimal-4.0.0.

@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2024
Closed
@skirpichev

This comment was marked as outdated.

Sign in to view
@skirpichev
pythongh-108562: fix compiler warnings for bundled libmpdec in the main …
8e514c5 
This patch enable (if awailable) -fstrict-overflow for libmpdec and also
shut off false positive warnings (-Warray-bounds).  The later part
was backported from mpdecimal-4.0.0.
@skirpichev skirpichev force-pushed the enable-strict-overflow-108562 branch from 3303b02 to 8e514c5 Compare January 30, 2024 13:44
@skirpichev skirpichev marked this pull request as ready for review January 30, 2024 13:46
sethmlarson
sethmlarson approved these changes Jan 30, 2024
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for updating the SBOM!

@rhettinger rhettinger removed their request for review January 30, 2024 23:11
@skirpichev

skirpichev commented Mar 3, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland, is this still waiting for review? Maybe I should ask Stefan (However, I think the decimal-related part was actually discussed in the issue)?

@erlend-aasland erlend-aasland merged commit 002a594 into python:main Mar 3, 2024
@skirpichev skirpichev deleted the enable-strict-overflow-108562 branch March 3, 2024 07:26
@erlend-aasland erlend-aasland mentioned this pull request Mar 4, 2024
Merged
@markshannon markshannon mentioned this pull request Mar 4, 2024
Merged
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@skirpichev @woodruffw
pythongh-108562: Fix compiler warnings for libmpdec (python#114751) …
b44c631 
If awailable, enable -fstrict-overflow for libmpdec. Also
shut off false positive warnings (-Warray-bounds).

The later was backported from mpdecimal-4.0.0.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@skirpichev @adorilson
pythongh-108562: Fix compiler warnings for libmpdec (python#114751) …
b65bb32 
If awailable, enable -fstrict-overflow for libmpdec. Also
shut off false positive warnings (-Warray-bounds).

The later was backported from mpdecimal-4.0.0.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@skirpichev @diegorusso
pythongh-108562: Fix compiler warnings for libmpdec (python#114751) …
38a87a1 
If awailable, enable -fstrict-overflow for libmpdec. Also
shut off false positive warnings (-Warray-bounds).

The later was backported from mpdecimal-4.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @erlend-aasland @sethmlarson