◐ Shell
reader mode source ↗
Skip to content

gh-101100: Fix dangling refs in bdb.rst#114983

Merged
hugovk merged 4 commits into
python:mainfrom
smontanaro:patch-2
Feb 11, 2024
Merged

gh-101100: Fix dangling refs in bdb.rst#114983
hugovk merged 4 commits into
python:mainfrom
smontanaro:patch-2

Conversation

@smontanaro

@smontanaro smontanaro commented Feb 4, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This should be fairly straightforward. I did one thing that isn't maybe strictly kosher. The Bdb.quitting attribute isn't directly documented, but is mentioned in the description of Bdb.set_quit(). I linked those occurrences to the description of set_quit.

📚 Documentation preview 📚: https://cpython-previews--114983.org.readthedocs.build/

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 4, 2024
Open
@smontanaro @aisk
Apply suggestions from code review …
ef1ba54 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
serhiy-storchaka
serhiy-storchaka approved these changes Feb 8, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@hugovk

hugovk commented Feb 10, 2024

Copy link
Copy Markdown
Member

@smontanaro Please could you update this PR to remove bdb.rst from .nitignore?

Congratulations! You improved:

Doc/library/bdb.rst

Please remove from Doc/tools/.nitignore

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 10, 2024
@smontanaro

smontanaro commented Feb 10, 2024

Copy link
Copy Markdown
Contributor Author

@hugovk Should be all set. If my aim at the start of one of these mini-projects is to get rid of all warnings from a file, should my initial PR remove it from .nitignore?

@hugovk

hugovk commented Feb 11, 2024

Copy link
Copy Markdown
Member

Yes please, we can consider each PR to be atomic so both (clean file, remove from .nitignore) are needed for the CI to pass, and the CI must pass for us to be able to merge.

@hugovk hugovk merged commit 1b89591 into python:main Feb 11, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

Thanks @smontanaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

Sorry, @smontanaro and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b895914742d20ccebd1b56b1b0936b7e00eb95e 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2024
@smontanaro @aisk @miss-islington
pythongh-101100: Fix dangling refs in bdb.rst (pythonGH-114983) …
02e61aa 
(cherry picked from commit 1b89591)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

GH-115284 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
hugovk pushed a commit that referenced this pull request Feb 11, 2024
@miss-islington @smontanaro @aisk
[3.11] gh-101100: Fix dangling refs in bdb.rst (GH-114983) (#115284) …
dd28e82 
gh-101100: Fix dangling refs in bdb.rst (GH-114983)
(cherry picked from commit 1b89591)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
smontanaro added a commit to smontanaro/cpython that referenced this pull request Feb 11, 2024
@smontanaro @aisk
pythongh-101100: Fix dangling refs in bdb.rst (python#114983) …
4dd4008 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
(cherry picked from commit 1b89591)
@smontanaro

smontanaro commented Feb 11, 2024

Copy link
Copy Markdown
Contributor Author

Cherries have been picked. I think I finally created the pull request against the correct branch (3.12). Given the standardized naming of the backport branch, it does seem peculiar that GitHub can't default to the relevant branch though...

@bedevere-app

bedevere-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

GH-115297 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 11, 2024
@AlexWaygood

AlexWaygood commented Feb 11, 2024

Copy link
Copy Markdown
Member

Cherries have been picked. I think I finally created the pull request against the correct branch (3.12). Given the standardized naming of the backport branch, it does seem peculiar that GitHub can't default to the relevant branch though...

Looks great! There was just one thing missing: a backport PR to the 3.12 branch has to have a PR title starting with [3.12] in order for bedevere to recognise it as a PR backporting this PR. I changed the title for you on #115297 :)

hugovk pushed a commit that referenced this pull request Feb 11, 2024
@smontanaro @aisk
[3.12] gh-101100: Fix dangling refs in bdb.rst (#114983) (#115297) …
18f5264 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Fix dangling refs in bdb.rst (#114983)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@smontanaro @aisk @fsc-eriker
pythongh-101100: Fix dangling refs in bdb.rst (python#114983) …
3c6deb3 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smontanaro @hugovk @AlexWaygood @aisk @serhiy-storchaka