[3.11] gh-101100: Fix Py_DEBUG dangling Sphinx references (#115003)#115141
[3.11] gh-101100: Fix Py_DEBUG dangling Sphinx references (#115003)#115141AlexWaygood merged 1 commit into
Conversation
(cherry picked from commit d0322fd)
|
@smontanaro, please make sure to select the correct base branch when creating backport PRs. If you try to merge a 3.11 backport PR into the |
Sorry, something went wrong.
I was on my 3.11 branch. In addition, the |
Sorry, something went wrong.
|
The branch was created correctly, based on |
Sorry, something went wrong.
Ah, that's the problem. It hadn't occurred to me that there was a choice to make at that step. I thought everything would just be correct. The first time I even tried to make a PR against anything but |
Sorry, something went wrong.
|
This sort of splat is common enough that must of us now know to check further emails to see if someone has already handled it before even clicking to do anything. Please keep contributing. This one was solved by re-basing and close/open to restart tests. Force-pushing sometimes results in a mess that requires closing and starting over with a new PR. Alex, Zachary: could we ask GH to add a way to clear the reviewer request list? Or either question or refuse to create PRs like this? Or add a hook that calls our code before making the PR? EDIT Or have we tried already? |
Sorry, something went wrong.
+1. Apologies if my first message was overly critical, @smontanaro :)
I recall us giving some informal feedback to GitHub some time ago that it would be nice to introduce some more friction to the PR-making process, to make this kind of thing less common. But I don't know that anything came of it; it might well be worth trying again |
Sorry, something went wrong.
|
No worries. You didn't put me off... In fact: https://discuss.python.org/t/dis-py-stack-append-vs-stack-push/45330 |
Sorry, something went wrong.
No change to 3.11 branch for
Doc/library/test.rstbecause the relevant section was new in 3.12.📚 Documentation preview 📚: https://cpython-previews--115141.org.readthedocs.build/