{{ message }}
bpo-24780: unittest assertEqual difference output foiled by newlines#11548
Closed
nanjekyejoannah wants to merge 3 commits into
Closed
bpo-24780: unittest assertEqual difference output foiled by newlines#11548nanjekyejoannah wants to merge 3 commits into
nanjekyejoannah wants to merge 3 commits into
Conversation
Contributor
Sorry, something went wrong.
tirkarthi
reviewed
Jan 14, 2019
nanjekyejoannah
force-pushed
the
issue24780
branch
from
222a928 to
df4bdc9
Compare
January 16, 2019 08:53
nanjekyejoannah
force-pushed
the
issue24780
branch
from
6467b25 to
819b341
Compare
January 16, 2019 09:06
Member
|
Thanks @nanjekyejoannah, tests should be fixed as noted in https://github.com/python/cpython/pull/11548/files#r247392463 . The tests are about the strings being equal and are not related to the issue. The actual tests should be about the diff output for the tests. |
Sorry, something went wrong.
Contributor
Author
|
closed this. Someone can open another PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
I have created a fix for this issue and relevant tests.
https://bugs.python.org/issue24780