bpo-35730: Use known good font in IDLE test_sqeezer#11552
Conversation
Tk guarantees that TkFixedFont exists.
I did that to prevent merging the change too early. First we have to make sure that the test pass on the Gentoo buildbot. |
Sorry, something went wrong.
|
@terryjreedy, this is a great fix! I just added a few minor comments. |
Sorry, something went wrong.
|
@vstinner Removing the backport label does not prevent merging. Omitting both news and skip news, which I did intentionally, with the intention to add one later, did prevent merging, at least initially. Adding skip news turned the button green and enabled merging ;-). Now, how does one force a particular buildbot to test a particular PR without merging? |
Sorry, something went wrong.
I don't want to block this PR. I want to block a backport to 3.7 until we can double check that this change fix the Gentoo buildbot on master. |
Sorry, something went wrong.
Use https://devguide.python.org/buildbots/#custom-builders to test your PR on all buildbots at once. If you only want to test on one specific buildbot, contact the buildbot worker owner who may or may not answer :-) |
Sorry, something went wrong.
|
I've triggered a run on all buildbots via EDIT: One of the relevant Gentoo builders had an error running the tests for the custom build: |
Sorry, something went wrong.
|
That's annoying. Looking at https://buildbot.python.org/all/#/grid, the only normally green buildbots to turn red are the 3 Gentoo bots. The other non-refleak bot had the same error on test startup. The refleaks bot did run the test, failing with '6 not greater than 6'. I strongly suspect from the latter that the fix would not work on the normal Gentoo bots and that there is something peculiar about tk on the Gentoo machine. I am inclined to let this sit a bit. In the latter, I noticed some new 'Theme Changed' messages from recent tests, including squeezer. I will look into at previous issues where I dealt with them. |
Sorry, something went wrong.
|
I've got another idea how to make this test work properly; see PR #11585. |
Sorry, something went wrong.
|
I merged the other solution, so closing this. |
Sorry, something went wrong.
Tk guarantees that TkFixedFont exists.
https://bugs.python.org/issue35730