◐ Shell
reader mode source ↗
Skip to content

gh-71052: Add Android build script#115576

Closed
mhsmith wants to merge 8 commits into
python:mainfrom
mhsmith:android-link
Closed

gh-71052: Add Android build script#115576
mhsmith wants to merge 8 commits into
python:mainfrom
mhsmith:android-link

Conversation

@mhsmith

@mhsmith mhsmith commented Feb 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR is the first significant step towards implementing Android support as specified in PEP 738. It includes:

@bedevere-app bedevere-app Bot mentioned this pull request Feb 16, 2024
Closed
erlend-aasland
erlend-aasland reviewed Feb 20, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I would be more comfortable if we could do the fixes in separate PRs:

  1. fix #111225
  2. then add the adjustments/refactorings (your middle bullet)
  3. add the README and the build script

@mhsmith

mhsmith commented Feb 21, 2024

Copy link
Copy Markdown
Member Author

I would be more comfortable if we could do the fixes in separate PRs:

OK, I'll do that. Here is the first one:

@mhsmith mhsmith closed this Feb 21, 2024
@mhsmith mhsmith mentioned this pull request Feb 26, 2024
Merged
This was referenced Mar 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cross Compile for Android and issues with PyExc_OSError

3 participants

@mhsmith @freakboy3742 @erlend-aasland