◐ Shell
reader mode source ↗
Skip to content

gh-115942: Add locked to several multiprocessing locks#115944

Merged
sobolevn merged 10 commits into
python:mainfrom
sobolevn:issue-115942
Apr 8, 2025
Merged

gh-115942: Add locked to several multiprocessing locks#115944
sobolevn merged 10 commits into
python:mainfrom
sobolevn:issue-115942

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

TODO:

  • Get field-expert's approval
  • Docs
  • News

@sobolevn sobolevn added the label Feb 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2024
Closed
@sobolevn sobolevn marked this pull request as ready for review March 13, 2024 06:44
@sobolevn sobolevn requested a review from gpshead as a code owner March 13, 2024 06:44
@sobolevn

sobolevn commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

@gpshead do you have an opinion about this? :)

@sobolevn

sobolevn commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

friendly ping @gpshead

@sobolevn @mpage
Update Modules/_threadmodule.c …
646c650 
Co-authored-by: mpage <mpage@cs.stanford.edu>
@gpshead

gpshead commented Mar 13, 2025

Copy link
Copy Markdown
Member

FWIW this PR makes sense to me.

@sobolevn

sobolevn commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Ok, then I will add all the missing details. Thanks a lot! 👍

vstinner
vstinner reviewed Apr 1, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please add tests on threading.RLock.locked().

picnixz
picnixz reviewed Apr 1, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Just some rewording. Otherwise, once tests requested by Victor are added, LGTM.

@sobolevn

sobolevn commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

@vstinner @gpshead this is now ready to be reviewed :)

@sobolevn sobolevn requested review from mpage and vstinner April 1, 2025 09:43
vstinner
vstinner approved these changes Apr 1, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@sobolevn @hugovk
Apply suggestions from code review …
1a50a20 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead
gpshead approved these changes Apr 8, 2025
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I wish I could object to this being a locked() method instead of a .locked property... but this is matching an existing ancient API on purpose so... LGTM.

@sobolevn sobolevn merged commit f7305a0 into python:main Apr 8, 2025
@sobolevn

sobolevn commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

Thanks everyone! 🎉

This was referenced Apr 15, 2025
Closed
Closed
@YvesDup YvesDup mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@gpshead gpshead

@vstinner vstinner vstinner approved these changes

@picnixz picnixz picnixz approved these changes

@mpage mpage Awaiting requested review from mpage

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @gpshead @vstinner @mpage @hugovk @picnixz