{{ message }}
bpo-35813: Added shared_memory submodule of multiprocessing.#11664
Merged
applio merged 8 commits intoFeb 2, 2019
Merged
Conversation
vpatov
reviewed
Jan 27, 2019
|
@applio: Please replace |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 FreeBSD 10-STABLE Non-Debug 3.x has failed when building commit e5ef45b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/167/builds/531 Click to see traceback logsTraceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd10.nondebug/build/Lib/test/_test_multiprocessing.py", line 1866, in test_default_timeout
self.assertEqual(len(results), barrier.parties)
AssertionError: 0 != 5
----------------------------------------------------------------------
Ran 324 tests in 348.271s
FAILED (failures=1, skipped=32)
|
Sorry, something went wrong.
ronaldoussoren
left a comment
Contributor
There was a problem hiding this comment.
I haven't reviewed most of the Python code, due to lack of documentation it is unclear what the intended behaviour of of the code is.
Sorry, something went wrong.
10 hidden conversations
Load more…
giampaolo
reviewed
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Tests and docs are still absent. Some cleanup remains to be done in the code as well but all appears to be functional and stable across platforms since the sprint in September 2018.
https://bugs.python.org/issue35813