◐ Shell
reader mode source ↗
Skip to content

bpo-35813: Added shared_memory submodule of multiprocessing.#11664

Merged
applio merged 8 commits into
python:masterfrom
applio:enh-mp-shared-memory
Feb 2, 2019
Merged

bpo-35813: Added shared_memory submodule of multiprocessing.#11664
applio merged 8 commits into
python:masterfrom
applio:enh-mp-shared-memory

Conversation

@applio

@applio applio commented Jan 24, 2019

Copy link
Copy Markdown
Member

Tests and docs are still absent. Some cleanup remains to be done in the code as well but all appears to be functional and stable across platforms since the sprint in September 2018.

https://bugs.python.org/issue35813

@applio applio merged commit e5ef45b into python:master Feb 2, 2019
@bedevere-bot

Copy link
Copy Markdown

@applio: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 10-STABLE Non-Debug 3.x has failed when building commit e5ef45b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/167/builds/531) and take a look at the build logs.
  4. Check if the failure is related to this commit (e5ef45b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/167/builds/531

Click to see traceback logs
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10.nondebug/build/Lib/test/_test_multiprocessing.py", line 1866, in test_default_timeout
    self.assertEqual(len(results), barrier.parties)
AssertionError: 0 != 5

----------------------------------------------------------------------

Ran 324 tests in 348.271s

FAILED (failures=1, skipped=32)

@ronaldoussoren ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I haven't reviewed most of the Python code, due to lack of documentation it is unclear what the intended behaviour of of the code is.

10 hidden conversations Load more…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants