{{ message }}
GH-70647: Deprecate strptime day of month parsing without a year present to avoid leap-year bugs#117107
Merged
encukou merged 9 commits intoApr 3, 2024
Merged
Conversation
Member
Sorry, something went wrong.
1 task
gpshead
commented
Mar 20, 2024
Member
Author
|
Documentation added, but I need to reconcile this with my proposed non deprecation related wording drafted in #116179. |
Sorry, something went wrong.
To passively encourage people to include such comments in their own code when adopting this mitigation...
encukou
reviewed
Apr 2, 2024
encukou
approved these changes
Apr 2, 2024
encukou
reviewed
Apr 2, 2024
pganssle
reviewed
Apr 2, 2024
pganssle
approved these changes
Apr 2, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…r present to avoid leap-year bugs (pythonGH-117107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
If we don't do this now, people will still be using Python releases that don't guide code away from the bug by the time the next leap year rolls around. :)
Decision on what our actual breaking change will be has been left for later, this just starts the process to allow us to do it with a suggestion of how to always avoid such problems in code.
TODO list: