◐ Shell
reader mode source ↗
Skip to content

gh-116622: Test updates for Android#117299

Merged
erlend-aasland merged 5 commits into
python:mainfrom
mhsmith:android-test-updates
Apr 5, 2024
Merged

gh-116622: Test updates for Android#117299
erlend-aasland merged 5 commits into
python:mainfrom
mhsmith:android-test-updates

Conversation

@mhsmith

@mhsmith mhsmith commented Mar 27, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR fixes various Android test issues which I've discovered over the last few weeks.

@bedevere-app bedevere-app Bot mentioned this pull request Mar 27, 2024
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 27, 2024
@mhsmith

mhsmith commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland: Are you able to review this PR? It's a continuation of the previous Android test updates from #115918.

erlend-aasland
erlend-aasland approved these changes Apr 5, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, with some nits. BTW, last time I checked, the sys.platform.startswith idiom was still recommended practice. I'd prefer if we could follow that.

@mhsmith

mhsmith commented Apr 5, 2024

Copy link
Copy Markdown
Member Author

The parentheses are not needed.

Fixed.

last time I checked, the sys.platform.startswith idiom was still recommended practice

I actually updated the sys.platform documentation in #116215 (comment) to limit this recommendation to FreeBSD. Ever since Python 3.3, all other PEP 11-supported platforms have returned a fixed string without a version number.

@erlend-aasland

erlend-aasland commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

@mhsmith, thanks for the heads-up, I missed that docs update (and I've must have looked at the 3.12 docs). Perhaps we should consider backporting that doc patch.

@erlend-aasland erlend-aasland enabled auto-merge (squash) April 5, 2024 20:54
@erlend-aasland erlend-aasland merged commit 1d3225a into python:main Apr 5, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@mhsmith @diegorusso
pythongh-116622: Test updates for Android (python#117299) …
9943b31 
- re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all
  Android ABIs
- use support.setswitchinterval in all relevant tests
- skip test_fma_zero_result on Android x86_64
- accept EACCES when calling os.get_terminal_size on Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhsmith @erlend-aasland