{{ message }}
bpo-35766 follow-up: Add an error check to new_type_comment()#11766
Merged
gvanrossum merged 1 commit intoFeb 11, 2019
Merged
Conversation
Member
Sorry, something went wrong.
If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash. Found by @msullivan for python/typed_ast#93.
|
@gvanrossum: Please replace |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 FreeBSD CURRENT Shared 3.x has failed when building commit 4b250fc. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/168/builds/562 Click to see traceback logsTraceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/process.py", line 302, in _bootstrap
self.run()
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/process.py", line 99, in run
self._target(*self._args, **self._kwargs)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/managers.py", line 572, in _run_server
writer.send(server.address)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/connection.py", line 206, in send
self._send_bytes(_ForkingPickler.dumps(obj))
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/connection.py", line 411, in _send_bytes
self._send(header + buf)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/connection.py", line 368, in _send
n = write(self._handle, buf)
BrokenPipeError: [Errno 32] Broken pipe
/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/process.py:318: ResourceWarning: unclosed <socket.socket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 19024)>
traceback.print_exc()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
|
Sorry, something went wrong.
Member
Author
|
I believe the buildbot failure is a false positive. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
If PyUnicode_DecodeUTF8() were to return
NULL,PyArena_AddPyObject()would crash.Found by @msullivan for python/typed_ast#93.
https://bugs.python.org/issue35766