◐ Shell
reader mode source ↗
Skip to content

gh-112730: use keyword only argument for colorize#118086

Closed
methane wants to merge 1 commit into
python:mainfrom
methane:traceback-kwonly
Closed

gh-112730: use keyword only argument for colorize#118086
methane wants to merge 1 commit into
python:mainfrom
methane:traceback-kwonly

Conversation

@methane

@methane methane commented Apr 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@methane methane requested a review from pablogsal April 19, 2024 07:19
@methane methane requested a review from iritkatriel as a code owner April 19, 2024 07:19
@bedevere-app bedevere-app Bot mentioned this pull request Apr 19, 2024
Closed
@methane

methane commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

sorry if there is a reason to use kwargs.

@methane

methane commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

Maybe, you don't want to expose this option as public API.

@methane methane closed this Apr 19, 2024
@maxeonyx

maxeonyx commented Oct 17, 2025

Copy link
Copy Markdown

@methane I think this was a good PR? Although changing away from **kwargs back to just a named arg means that this change would break anyone providing invalid args.

And yeah possibly they didn't want to expose it? But why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@methane @maxeonyx