{{ message }}
gh-117783: Immortalize objects that use deferred reference counting#118112
Merged
colesbury merged 6 commits intoApr 29, 2024
Merged
gh-117783: Immortalize objects that use deferred reference counting#118112colesbury merged 6 commits into
colesbury merged 6 commits into
Conversation
Contributor
Sorry, something went wrong.
…ting Deferred reference counting is not fully implemented yet. As a temporary measure, we immortalize objects that would use deferred reference counting to avoid multi-threaded scaling bottlenecks. This is only performed in the free-threaded build once the first non-main thread is started. Additionally, some tests, including refleak tests, suppress this behavior.
colesbury
added
the
🔨 test-with-refleak-buildbots
Test PR w/ refleak buildbots; report in status section
label
Apr 19, 2024
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 0cab82c 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Test PR w/ refleak buildbots; report in status section
label
Apr 19, 2024
colesbury
requested review from
ericsnowcurrently and
rhettinger
as code owners
April 19, 2024 21:37
DinoV
reviewed
Apr 22, 2024
DinoV
approved these changes
Apr 29, 2024
DinoV
left a comment
DinoV
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Deferred reference counting is not fully implemented yet. As a temporary measure, we immortalize objects that would use deferred reference counting to avoid multi-threaded scaling bottlenecks.
This is only performed in the free-threaded build once the first non-main thread is started. Additionally, some tests, including refleak tests, suppress this behavior.