GH-115775: Use __static_attributes__ to initialize shared keys#118468
Conversation
dedffa7 to
5032ad9
Compare
May 1, 2024 13:56
846a7ef to
a7b858b
Compare
May 2, 2024 10:47
b64de3d to
d54afaf
Compare
May 3, 2024 18:30
|
The stats are not obviously better. This PR reduces misses in Both From this, it appears that this PR does what it aims to do. It also appears that it would be worth improving our handling of shadowed attributes. I plan to fix the shadowing issue before merging this, so that it becomes a clear improvement |
Sorry, something went wrong.
|
Now that #123040 is fixed things look much better. Performance shows no change apart from the "go" benchmark speeds up by 35%. The "go" benchmark creates many objects before initializing them, which is a pattern that this PR allows us to optimize. The stats show a small increase in specialization of |
Sorry, something went wrong.
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.