{{ message }}
gh-118803: Remove ByteString from typing and collections.abc#118804
Merged
AlexWaygood merged 2 commits intoMay 8, 2024
Merged
gh-118803: Remove ByteString from typing and collections.abc#118804AlexWaygood merged 2 commits into
ByteString from typing and collections.abc#118804AlexWaygood merged 2 commits into
Conversation
rhettinger
approved these changes
May 8, 2024
JelleZijlstra
approved these changes
May 8, 2024
AlexWaygood
approved these changes
May 8, 2024
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Contributor
|
Left a longer comment on the issue but to summarize I was a bit surprised to discover that just importing |
Sorry, something went wrong.
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Sep 16, 2025
…ctions.abc` (python#118804)" This reverts commit 2f4db5a.
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Sep 16, 2025
…ctions.abc` (python#118804)" This reverts commit 2f4db5a.
AlexWaygood
added a commit
that referenced
this pull request
Sep 16, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 16, 2025
…ctions.abc` (pythonGH-118804)" (pythonGH-138990) (cherry picked from commit 530ddd3) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit 530ddd3. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/567/builds/10135 Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
ByteStringfromtypingandcollections.abc#118803📚 Documentation preview 📚: https://cpython-previews--118804.org.readthedocs.build/