{{ message }}
Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)"#118861
Merged
colesbury merged 1 commit intoMay 9, 2024
Merged
Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)"#118861colesbury merged 1 commit into
colesbury merged 1 commit into
Conversation
Contributor
Sorry, something went wrong.
…NULL object (python#115433)" This reverts commit ad4f909. The API ended up not being used.
Contributor
Author
|
@Yhg1s - this isn't really a bug fix, but it's definitely not a feature. Would it be appropriate to backport this revert to 3.13? |
Sorry, something went wrong.
colesbury
force-pushed
the
gh-115432-revert
branch
from
9f8175b to
49a359e
Compare
May 9, 2024 18:26
DinoV
approved these changes
May 9, 2024
DinoV
left a comment
DinoV
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Member
|
Yeah, backporting it to 3.13 is fine until we get to rc1. |
Sorry, something went wrong.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
…NULL object (pythonGH-115433)" (pythonGH-118861) This reverts commit ad4f909. The API ended up not being used. (cherry picked from commit 46c8081) Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
…NULL object (python#115433)" (python#118861) This reverts commit ad4f909. The API ended up not being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit ad4f909.
This internal API ended up not being used.
Py_BEGIN_CRITICAL_SECTIONthat accepts aNULLargument #115432