◐ Shell
reader mode source ↗
Skip to content

gh-118899: Add tests for NotImplemented attribute access#118902

Merged
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-118899
May 12, 2024
Merged

gh-118899: Add tests for NotImplemented attribute access#118902
sobolevn merged 3 commits into
python:mainfrom
sobolevn:issue-118899

Conversation

@sobolevn

@sobolevn sobolevn commented May 10, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn sobolevn requested a review from JelleZijlstra May 10, 2024 13:36
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 10, 2024
Closed
@sobolevn sobolevn enabled auto-merge (squash) May 12, 2024 13:46
@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 12, 2024
@sobolevn

sobolevn commented May 12, 2024

Copy link
Copy Markdown
Member Author

Test changes are usually backported.

@sobolevn sobolevn merged commit ec1398e into python:main May 12, 2024
@miss-islington-app

miss-islington-app Bot commented May 12, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt… …
bccb0fa 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented May 12, 2024

Copy link
Copy Markdown

GH-118968 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt… …
351358b 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 12, 2024
@bedevere-app

bedevere-app Bot commented May 12, 2024

Copy link
Copy Markdown

GH-118969 is a backport of this pull request to the 3.12 branch.

sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.12] gh-118899: Add tests for NotImplemented attribute access (GH… …
76dc1bf 
…-118902) (#118969)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request May 12, 2024
@miss-islington @sobolevn
[3.13] gh-118899: Add tests for NotImplemented attribute access (GH… …
6e855b3 
…-118902) (#118968)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-118899: Add tests for NotImplemented attribute access (pyt… …
2f6b607 
…hon#118902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @JelleZijlstra