gh-119009: Add gettext target#119006
Conversation
Sorry, something went wrong.
d05ab47 to
5254761
Compare
May 13, 2024 17:15
|
Could you copy details on the problem and proposed solution in a github issue? For CPython we like to have the problem discussed in an issue, and discusson on the PR can be focussed on the implementation itself. For this ticket there probably won’t be any debate on the issue, but I wanted to clarify this part of the workflow for future contributions! |
Sorry, something went wrong.
Sure, issue opened. |
Sorry, something went wrong.
|
Please could you add a help entry (see line 30) so it shows up in: ❯ make -C Doc help
Please use `make <target>' where <target> is one of
clean to remove build files
venv to create a venv with necessary tools
html to make standalone HTML files
htmlview to open the index page built by the html target in your browser
htmllive to rebuild and reload HTML files in your browser
htmlhelp to make HTML files and a HTML help project
latex to make LaTeX files, you can set PAPER=a4 or PAPER=letter
text to make plain text files
texinfo to make Texinfo file
epub to make EPUB files
changes to make an overview over all changed/added/deprecated items
linkcheck to check all external links for integrity
coverage to check documentation coverage for library and C API
doctest to run doctests in the documentation
pydoc-topics to regenerate the pydoc topics file
dist to create a "dist" directory with archived docs for download
check to run a check for frequent markup errors |
Sorry, something went wrong.
|
I get an error running this, what am I missing? ❯ make -C Doc gettext
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
/Users/hugo/github/python/cpython/main/Doc/build/NEWS is already up to date
PATH=./venv/bin:$PATH sphinx-build -b gettext -d build/doctrees -j auto -W . build/gettext
Running Sphinx v7.3.7
loading pickled environment... done
Sphinx error:
This environment is incompatible with the selected builder, please choose another doctree directory.
make: *** [build] Error 2That's from the repo root. I get the same thing with |
Sorry, something went wrong.
|
Oh, I've seen it before. I believe to be something related to the doctree being in the same directory, but I didn't dig for the reason. |
Sorry, something went wrong.
|
I pushed a workaround: set another doctree directory for gettext. |
Sorry, something went wrong.
hugovk
left a comment
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
|
Thanks @rffontenelle for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
(cherry picked from commit fb0cf7d) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
(cherry picked from commit fb0cf7d) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
edited by hugovk
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.