◐ Shell
reader mode source ↗
Skip to content

gh-119317: findall instead of traverse for docutils nodes#119319

Merged
hugovk merged 1 commit into
python:mainfrom
drts01:fix_docs_tools_deprecation_warnings_119317
May 24, 2024
Merged

gh-119317: findall instead of traverse for docutils nodes#119319
hugovk merged 1 commit into
python:mainfrom
drts01:fix_docs_tools_deprecation_warnings_119317

Conversation

@drts01

@drts01 drts01 commented May 21, 2024 •
edited by hugovk
Loading

Copy link
Copy Markdown
Contributor

The new method, findall, is a generator rather than returning a list.

closes #119317

@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2024
Closed
@drts01 drts01 force-pushed the fix_docs_tools_deprecation_warnings_119317 branch from 2312026 to 3830593 Compare May 21, 2024 16:11
@bedevere-app

bedevere-app Bot commented May 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@willingc willingc added docs Documentation in the Doc dir skip news labels May 21, 2024
@hugovk

hugovk commented May 24, 2024

Copy link
Copy Markdown
Member

Thank you.

@hugovk hugovk merged commit 0867bce into python:main May 24, 2024
@miss-islington-app

miss-islington-app Bot commented May 24, 2024

Copy link
Copy Markdown

Thanks @xsc27 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@drts01 @miss-islington
pythongh-119317: findall instead of traverse for docutils nodes (pyth… …
09b3794 
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119486 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@drts01 @miss-islington
pythongh-119317: findall instead of traverse for docutils nodes (pyth… …
dd7d926 
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119487 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 24, 2024
hugovk pushed a commit that referenced this pull request May 24, 2024
@miss-islington @drts01
[3.12] gh-119317: findall instead of traverse for docutils nodes (GH-… …
2b091b9 
…119319) (#119487)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
hugovk pushed a commit that referenced this pull request May 27, 2024
@miss-islington @drts01
[3.13] gh-119317: findall instead of traverse for docutils nodes (GH-… …
7322ff1 
…119319) (#119486)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@drts01 @estyxx
pythongh-119317: findall instead of traverse for docutils nodes (pyth… …
94e2e3e 
…on#119319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resolve deprecation warnings in Docs/tools

3 participants

@drts01 @hugovk @willingc