◐ Shell
reader mode source ↗
Skip to content

gh-69214: Fix fcntl.ioctl() request type#119498

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ioctl_long
May 24, 2024
Merged

gh-69214: Fix fcntl.ioctl() request type#119498
vstinner merged 1 commit into
python:mainfrom
vstinner:ioctl_long

Conversation

@vstinner

@vstinner vstinner commented May 24, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

@vstinner
pythongh-69214: Fix fcntl.ioctl() request type …
7bb6068 
Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 24, 2024
Closed
@vstinner

vstinner commented May 24, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka approved these changes May 24, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

It could be better, because in POSIX its type is int, and on Linux we can make it stricter with bitwise=False , but this is good enough.

@vstinner vstinner merged commit 92fab33 into python:main May 24, 2024
@vstinner vstinner deleted the ioctl_long branch May 24, 2024 12:31
@miss-islington-app

miss-islington-app Bot commented May 24, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@vstinner @miss-islington
pythongh-69214: Fix fcntl.ioctl() request type (pythonGH-119498) …
bd62cde 
Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
(cherry picked from commit 92fab33)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington-app

miss-islington-app Bot commented May 24, 2024

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 92fab3356f4c61d4c73606e4fae705c6d8f6213b 3.12

@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119504 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
@bedevere-app

bedevere-app Bot commented May 24, 2024

Copy link
Copy Markdown

GH-119505 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 24, 2024
@vstinner

vstinner commented May 24, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.

vstinner added a commit to vstinner/cpython that referenced this pull request May 24, 2024
@vstinner
pythongh-69214: Fix fcntl.ioctl() request type (python#119498) …
729941c 
Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

(cherry picked from commit 92fab33)
vstinner added a commit that referenced this pull request May 24, 2024
@vstinner
[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498) (#119505) …
078da88 
gh-69214: Fix fcntl.ioctl() request type (#119498)

Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

(cherry picked from commit 92fab33)
vstinner added a commit that referenced this pull request May 24, 2024
@miss-islington @vstinner
[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-119498) (#119504) …
0bab0b3 
gh-69214: Fix fcntl.ioctl() request type (GH-119498)

Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
(cherry picked from commit 92fab33)

Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
Revert "[3.13] pythongh-69214: Fix fcntl.ioctl() request type (python… …
517b639 
…GH-119498) (python#119504)"

This reverts commit 0bab0b3.
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
Revert "[3.13] pythongh-69214: Fix fcntl.ioctl() request type (python… …
63ae381 
…GH-119498) (python#119504)"

This reverts commit 0bab0b3.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (python… …
965b4b7 
…#119498) (python#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
vstinner added a commit that referenced this pull request Jun 1, 2024
@vstinner
[3.12] Revert "[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498… …
34a0e7a 
…) (#1… (#119905)

Revert "[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498) (#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
vstinner added a commit that referenced this pull request Jun 1, 2024
@vstinner
[3.13] Revert "[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-11… …
4e147ca 
…9498) (… (#119906)

Revert "[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-119498) (#119504)"

This reverts commit 0bab0b3.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-69214: Fix fcntl.ioctl() request type (python#119498) …
703410b 
Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @serhiy-storchaka