◐ Shell
reader mode source ↗
Skip to content

gh-109218: Refactor tests for the complex() constructor#119635

Merged
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:complex-constructor-tests
May 30, 2024
Merged

gh-109218: Refactor tests for the complex() constructor#119635
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:complex-constructor-tests

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 27, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Share common classes.
  • Use exactly representable floats and exact tests.
  • Check the sign of zero components.
  • Remove duplicated tests (mostly left after merging int and long).
  • Reorder tests in more consistent way.
  • Test more error messages.
  • Add tests for missed cases.

@serhiy-storchaka
pythongh-109218: Refactor tests for the complex() constructor …
c35779b 
* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2024
Closed
skirpichev
skirpichev approved these changes May 28, 2024
View reviewed changes

@skirpichev skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, just few nitpicks. No test coverage regressions.

@serhiy-storchaka serhiy-storchaka mentioned this pull request May 28, 2024
Merged
mdickinson
mdickinson approved these changes May 29, 2024
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Changes LGTM

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) May 29, 2024 18:25
@serhiy-storchaka serhiy-storchaka merged commit bf098d4 into python:main May 30, 2024
@miss-islington-app

miss-islington-app Bot commented May 30, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
@serhiy-storchaka @miss-islington
pythongh-109218: Refactor tests for the complex() constructor (python… …
354f797 
…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
@serhiy-storchaka @miss-islington
pythongh-109218: Refactor tests for the complex() constructor (python… …
b7379b9 
…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented May 30, 2024

Copy link
Copy Markdown

GH-119795 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 30, 2024
@bedevere-app

bedevere-app Bot commented May 30, 2024

Copy link
Copy Markdown

GH-119796 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 30, 2024
serhiy-storchaka added a commit that referenced this pull request May 30, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-109218: Refactor tests for the complex() constructor (GH-11… …
2e31e56 
…9635) (GH-119796)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@serhiy-storchaka @noahbkim
pythongh-109218: Refactor tests for the complex() constructor (python… …
d41a832 
…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-109218: Refactor tests for the complex() constructor (python… …
23d4599 
…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
serhiy-storchaka added a commit that referenced this pull request Aug 9, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-109218: Refactor tests for the complex() constructor (GH-11… …
013752c 
…9635) (GH-119795)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

+1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @mdickinson @skirpichev