gh-97850: remove find_loader and get_loader from pkgutil#119656
Conversation
|
Quick question but how do you manage the whatsnews sections when a feature is being removed? I cannot really change it to |
Sorry, something went wrong.
find_loader and get_loader from pkgutil|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
Yes, that's what I was actually asking. Should I just suppress every possible links in the others 3.x.rst files even though they exist? (if so, I can do it but I wanted to be sure that all references should be suppressed even for old versions for which the reference would exist). |
Sorry, something went wrong.
|
Again, older versions won't be affected, because they live in their own branches. And we won't backport this change. |
Sorry, something went wrong.
|
Oh yes, it was dumb of me. I incorrectly assumed that the 3.12 page was for the corresponding branch (seems I'm still not entirely awake). Anyway, I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @sobolevn: please review the changes made to this pull request. |
Sorry, something went wrong.
sobolevn
left a comment
There was a problem hiding this comment.
Sorry, I somehow did not send this comment.
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Oh, I forgot about this one :') I'll fix the conflicts err... I don't know when (I'm a bit busy writing something currently and don't know if I'll have tomorrow) |
Sorry, something went wrong.
|
Thanks, absolutely no rush with this :) |
Sorry, something went wrong.
…n into remove-deprecated-pkgutil
|
@picnixz are you waiting on anything for this? You haven't triggered a request for a re-review. |
Sorry, something went wrong.
|
Oh I forgot about it. This one is a low-priority task (which is why I didn't re-request a review) and we were waiting for more experts feedback (such as yours I think?) so we can address this issue when people have the time! (I'll be barely present for the rest of the week) |
Sorry, something went wrong.
|
Where are we up to here? Our friends at Fedora, who do a huge amount of valuable early testing and fixing of Python packages, are asking about pending deprecations for 3.14: |
Sorry, something went wrong.
|
I always forget about this PR :D We actually waited for an expert on pkgutil to confirm that the removal is ok. Apart from that, I don't think I wanted to do more. I'll ask a round of re-review. |
Sorry, something went wrong.
There is no pkgutil expert, hence the deprecation (that and it not plugging into importlib cleanly). 😉 |
Sorry, something went wrong.
|
Let's merge! |
Sorry, something went wrong.
…til`` (python#119656) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
…til`` (python#119656) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
See:
📚 Documentation preview 📚: https://cpython-previews--119656.org.readthedocs.build/