◐ Shell
reader mode source ↗
Skip to content

gh-119655: Fix reference leak in the _datetimemodule.c#119713

Merged
ericsnowcurrently merged 3 commits into
python:mainfrom
Eclips4:issue-119655
May 29, 2024
Merged

gh-119655: Fix reference leak in the _datetimemodule.c#119713
ericsnowcurrently merged 3 commits into
python:mainfrom
Eclips4:issue-119655

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 29, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@Eclips4 Eclips4 requested review from abalkin and pganssle as code owners May 29, 2024 08:29
@bedevere-app bedevere-app Bot mentioned this pull request May 29, 2024
Closed
erlend-aasland
erlend-aasland approved these changes May 29, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

ericsnowcurrently
ericsnowcurrently approved these changes May 29, 2024
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@ericsnowcurrently ericsnowcurrently merged commit 34f9b3e into python:main May 29, 2024
@ericsnowcurrently

ericsnowcurrently commented May 29, 2024

Copy link
Copy Markdown
Member

FYI, I'm going to add this change to gh-119695, which is the backport of gh-119637 to 3.13.

ericsnowcurrently added a commit to miss-islington/cpython that referenced this pull request May 29, 2024
@ericsnowcurrently
pythongh-119655: Fix reference leak in the _datetimemodule.c (pythong… …
36aa3f5 
…h-119713)
@Eclips4 Eclips4 deleted the issue-119655 branch May 29, 2024 18:21
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4 @noahbkim
pythongh-119655: Fix reference leak in the _datetimemodule.c (pyt… …
0761f74 
…hongh-119713)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @estyxx
pythongh-119655: Fix reference leak in the _datetimemodule.c (pyt… …
47be084 
…hongh-119713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@encukou encukou Awaiting requested review from encukou

@pganssle pganssle Awaiting requested review from pganssle

@abalkin abalkin

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eclips4 @ericsnowcurrently @erlend-aasland