◐ Shell
reader mode source ↗
Skip to content

bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters#11984

Closed
sir-sigurd wants to merge 1 commit into
python:mainfrom
sir-sigurd:sqlite-converter-segfault
Closed

bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters#11984
sir-sigurd wants to merge 1 commit into
python:mainfrom
sir-sigurd:sqlite-converter-segfault

Conversation

@sir-sigurd

@sir-sigurd sir-sigurd commented Feb 22, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@sir-sigurd sir-sigurd force-pushed the sqlite-converter-segfault branch from 6a8c1fb to f1a838a Compare February 22, 2019 07:50
@BoboTiG

BoboTiG commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @sir-sigurd, I think a NEWs entry would be interesting, don't you?

@sir-sigurd sir-sigurd requested a review from berkerpeksag as a code owner June 22, 2019 05:22
@sir-sigurd sir-sigurd force-pushed the sqlite-converter-segfault branch 2 times, most recently from 16a6d90 to 6f1b983 Compare June 22, 2019 10:27
@erlend-aasland

erlend-aasland commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

@sir-sigurd, can you rebase onto master?

@sir-sigurd

sir-sigurd commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland
I'll try to rebase in the near future, though I almost do not remember anything about this.

@erlend-aasland

erlend-aasland commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

I'll try to rebase in the near future, though I almost do not remember anything about this.

Thanks, there's no hurry :)

@sir-sigurd sir-sigurd force-pushed the sqlite-converter-segfault branch from d3a828d to c79e784 Compare April 12, 2021 08:14
erlend-aasland
erlend-aasland approved these changes Jun 16, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

@erlend-aasland

erlend-aasland commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

@serhiy-storchaka would you mind reviewing this?

@erlend-aasland

erlend-aasland commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Could you rebase again (bco. GH-27884), @sir-sigurd? :)

Also, please clean up the regression test:

  • line length is limited to 79 chars
  • please use double quotes

@erlend-aasland erlend-aasland mentioned this pull request Oct 19, 2021
Merged
@sir-sigurd

sir-sigurd commented Nov 17, 2021

Copy link
Copy Markdown
Contributor Author

Closed in favor of GH-29054.

@sir-sigurd sir-sigurd closed this Nov 17, 2021
@sir-sigurd sir-sigurd deleted the sqlite-converter-segfault branch November 17, 2021 04:17
@sir-sigurd sir-sigurd mannequin mentioned this pull request Apr 10, 2022
Closed
heitbaum added a commit to heitbaum/LibreELEC.tv that referenced this pull request May 17, 2022
@heitbaum
Python3: update to 3.9.13 …
5c655c7 
release:
- https://www.python.org/downloads/release/python-3913/
changelog:
- https://docs.python.org/release/3.9.13/whatsnew/changelog.html

upstream fix for dropped patch
- python/cpython#80254
- python/cpython#11984
- python/cpython#90228
- python/cpython#92036
- python/cpython#92037
- python/cpython#92297
- bpo-36073
- was
  - python/cpython#30579
  - python/cpython#30580
@heitbaum heitbaum mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

+2 more reviewers

@BoboTiG BoboTiG BoboTiG left review comments

@auvipy auvipy

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sir-sigurd @BoboTiG @erlend-aasland @auvipy @the-knights-who-say-ni @bedevere-bot