◐ Shell
reader mode source ↗
Skip to content

gh-126782: Support qualified referencing for ntpath.abspath()#119849

Closed
nineteendo wants to merge 12 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath
Closed

gh-126782: Support qualified referencing for ntpath.abspath()#119849
nineteendo wants to merge 12 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath

Conversation

@nineteendo

@nineteendo nineteendo commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
Closed
@nineteendo nineteendo changed the title gh-119826: Improve accuracy of `ntpath.normpath() & ntpath.abspath() May 31, 2024
@nineteendo nineteendo marked this pull request as ready for review May 31, 2024 13:34
@nineteendo nineteendo changed the title gh-119826: Improve accuracy of ntpath.normpath() & ntpath.abspath() Jun 2, 2024
@nineteendo

This comment was marked as outdated.

Sign in to view
@nineteendo

This comment was marked as outdated.

Sign in to view
44 hidden items Load more…
@nineteendo

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

I never rebase, when I force push it's to redo a merge commit which failed here.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 13, 2024
Open
@nineteendo
Update and rename 2024-05-31-12-44-38.gh-issue-119826.Atm9ol.rst to 2… …
e3e42c5 
…024-05-31-12-44-38.gh-issue-126782.Atm9ol.rst
@nineteendo

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

I'll fix the drive relative paths in a separate PR.

@ZeroIntensity

ZeroIntensity commented Nov 13, 2024

Copy link
Copy Markdown
Member

Two notes:

  • Please don't change the target issue after the PR has been opened, it makes it harder to track discussion.
  • I'd really prefer that this PR get closed and reopened as a fresh PR under the new issue. Incorrectly rebasing triggers a review from all the codeowners, and they don't get unsubscribed even after their review request is removed.

@nineteendo

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Sorry for the chaos.

@nineteendo

nineteendo commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

It wasn't a rebase, I made a merge commit locally, but I realised I forgot to add the generated code. So I reset my head and committed without restarting the merge, causing the reviews to be requested. I force pushed afterwards to revert this commit in the hope it would remove the reviews (it didn't) with the intention of trying again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale Awaiting requested review from barneygale

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nineteendo @erlend-aasland @ZeroIntensity