◐ Shell
reader mode source ↗
Skip to content

gh-112026: Deprecate _PyDict_GetItemStringWithError() function#119855

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:depr_pydict_witherr
Jun 3, 2024
Merged

gh-112026: Deprecate _PyDict_GetItemStringWithError() function#119855
vstinner merged 1 commit into
python:mainfrom
vstinner:depr_pydict_witherr

Conversation

@vstinner

@vstinner vstinner commented May 31, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the label May 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
Closed
@vstinner

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

The function was removed in Python 3.13 alpha1 and added back to Python 3.13 alpha2 by #112119.

@vstinner vstinner mentioned this pull request May 31, 2024
Merged
@vstinner

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka reviewed Jun 1, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I do not think we should bother with deprecating the internal C API. It can be removed or changed in incompatible way at any time.

@serhiy-storchaka

serhiy-storchaka commented Jun 1, 2024

Copy link
Copy Markdown
Member

_PyDict_GetItemStringWithError() is just a wrapper around PyDict_GetItemWithError(). There are no reasons of using it instead of your own wrapper around PyDict_GetItemWithError().

@vstinner

vstinner commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

numpy and other projects used it. numpy was updated to use PyDict_GetItemStringRef() using pythoncapi-compat.

@vstinner vstinner merged commit 70934fb into python:main Jun 3, 2024
@vstinner vstinner deleted the depr_pydict_witherr branch June 3, 2024 08:26
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@vstinner @mliezun
pythongh-112026: Deprecate _PyDict_GetItemStringWithError() function (p… …
77d328b 
…ython#119855)
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@vstinner @barneygale
pythongh-112026: Deprecate _PyDict_GetItemStringWithError() function (p… …
02f2a16 
…ython#119855)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-112026: Deprecate _PyDict_GetItemStringWithError() function (p… …
c2862b1 
…ython#119855)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-112026: Deprecate _PyDict_GetItemStringWithError() function (p… …
b822e58 
…ython#119855)
@cdce8p cdce8p mentioned this pull request Oct 13, 2024
Merged
JukkaL pushed a commit to python/mypy that referenced this pull request Oct 16, 2024
@cdce8p
[mypyc] Replace deprecated _PyDict_GetItemStringWithError (#17930) …
f63fdb3 
`_PyDict_GetItemStringWithError ` was deprecated for Python 3.14 in
python/cpython#119855.
Use `PyDict_GetItemStringRef` instead. It was added in 3.13 but is
available via `pythoncapi_compat.h`.

https://docs.python.org/3/c-api/dict.html#c.PyDict_GetItemStringRef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @serhiy-storchaka