◐ Shell
reader mode source ↗
Skip to content

gh-119180: Add annotationlib module to support PEP 649#119891

Merged
JelleZijlstra merged 136 commits into
python:mainfrom
JelleZijlstra:pep649-inspect
Jul 23, 2024
Merged

gh-119180: Add annotationlib module to support PEP 649#119891
JelleZijlstra merged 136 commits into
python:mainfrom
JelleZijlstra:pep649-inspect

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jun 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR implements the annotationlib module proposed by PEP-749, as well as related Python changes for PEP-649 and PEP-749.

@JelleZijlstra
Add __annotate__ descriptors
985f8df
@JelleZijlstra
fix refleaks
c822ffa
@JelleZijlstra
blurb
e80095e
@JelleZijlstra
Fix some tests
90ff2c4
@JelleZijlstra
regen globals
026c0ff
@JelleZijlstra
Some initial work
7968744
@JelleZijlstra
Add bytecode for adding annotate
4e54197
@JelleZijlstra
compiler changes
4469b32
@JelleZijlstra
Functions work
47d672e
@JelleZijlstra
Raise AssertionError on the wrong format
ab9359c
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep649-compile
e65d55a
@JelleZijlstra
Modules and classes
e50cd62
@JelleZijlstra
attempts
afae5c0
@JelleZijlstra
Fixes
e5a7b1a
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep649-compile
3f26d44
@JelleZijlstra
Fix code object name
31a4471
@JelleZijlstra
Start fixing test_type_annotations
fbb1d88
@JelleZijlstra
Fix class scoping
f452eb2
@JelleZijlstra
unyielding
8c4b4e3
@JelleZijlstra
Fix test_typing
cbf9a3d
@JelleZijlstra
Fix test_type_parmas
5d182fc
@JelleZijlstra
Add test, add to inspect
ce98c19
@JelleZijlstra
Use inspect constants
e0578fc
@JelleZijlstra
test_grammar tweaks
ed16167
@JelleZijlstra
fix test_positional_only_arg
f38de20
@JelleZijlstra
Fix test_module
87baca2
@JelleZijlstra
Fix symtable tests
355d3df
@JelleZijlstra
fix test_pydoc
f9d81b6
@JelleZijlstra
fix test_traceback
dd1f64a
@JelleZijlstra
fix test_opcodes
62f5b3b
135 hidden items Load more…
@rhettinger rhettinger removed their request for review June 17, 2024 02:18
@JelleZijlstra

JelleZijlstra commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

This PR is still ready for review. While we will likely make some change related to metaclasses, that won't materially effect the changes here. I'd like to get this PR landed as a foundation to build the rest of the PEP implementation on, so I'd appreciate any reviews.

@JelleZijlstra JelleZijlstra mentioned this pull request Jul 21, 2024
Merged
carljm
carljm approved these changes Jul 23, 2024
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks good to me!

@JelleZijlstra

JelleZijlstra commented Jul 23, 2024

Copy link
Copy Markdown
Member Author

Thanks @carljm for the review! I pushed fixes for the issues you identified.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) July 23, 2024 20:48
@JelleZijlstra JelleZijlstra merged commit 7b7b90d into python:main Jul 23, 2024
@JelleZijlstra JelleZijlstra deleted the pep649-inspect branch July 23, 2024 21:20
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@JelleZijlstra @AlexWaygood @nohlson
pythongh-119180: Add annotationlib module to support PEP 649 (pytho… …
513dd5d 
…n#119891)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@JelleZijlstra @AlexWaygood @nohlson
pythongh-119180: Add annotationlib module to support PEP 649 (pytho… …
9fd92ac 
…n#119891)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk hugovk mentioned this pull request Aug 4, 2024
Closed
@Zac-HD Zac-HD mentioned this pull request Aug 11, 2024
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request Sep 17, 2024
Open
@hroncok hroncok mentioned this pull request Oct 29, 2024
Closed
@Daraan Daraan mentioned this pull request Oct 30, 2024
Merged
@yashwanthatla yashwanthatla mentioned this pull request Jun 21, 2025
Open
@johnslavik johnslavik mentioned this pull request Jan 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@carljm carljm

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra @carljm @picnixz @AlexWaygood