◐ Shell
reader mode source ↗
Skip to content

bpo-29569: threading.Timer class: Continue periodical execution till action return True#121

Closed
slytomcat wants to merge 6 commits into
python:masterfrom
slytomcat:master
Closed

bpo-29569: threading.Timer class: Continue periodical execution till action return True#121
slytomcat wants to merge 6 commits into
python:masterfrom
slytomcat:master

Conversation

@slytomcat

@slytomcat slytomcat commented Feb 15, 2017 •
edited
Loading

Copy link
Copy Markdown

I think that functionality of threading.Timer class can be easily extended to generate the sequence of runs with specified period. The idea comes from the GLib.timeout_add function.

http://bugs.python.org/issue29569

As most current CB functions that are used in Timer returns nothing (None) they will run only once as earlier. Only functions that returns True will continue their periodical execution.

There are two ways to stop such continues execution:

  • Return something that is not True from action function,
  • Call cancel method of Timer class.

It is my first contribution and I kindly ask to help me with required future actions.

Thanks

@slytomcat slytomcat changed the title threading.Timer class: Continue periodical execution till action retun True Feb 15, 2017
@slytomcat

slytomcat commented Feb 15, 2017

Copy link
Copy Markdown
Author

I've fixed test for continuous execution of Timer class. Now check passed.

@andrewnester

andrewnester commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

I am wondering how it will influence existing code. Most of the functions currently used in Timer callback probably not returning True value. It means that they will be executed infinitely.

Maybe it's better to add some new argument like repeat_until which takes some callback indicating when to finish execution. By default it will have some value to indicate only 1 repeat of callback execution.

@slytomcat

slytomcat commented Feb 15, 2017

Copy link
Copy Markdown
Author

No, exactly conversely - if function returns None or not True it will run only once.
The only returning True continues execution after next timeout.

@andrewnester

andrewnester commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

@slytomcat right, sorry, my bad

@slytomcat

slytomcat commented Feb 15, 2017

Copy link
Copy Markdown
Author

codecov/patch — 81.25% of diff hit (target 100%) - anybody know how to fix it?

@slytomcat slytomcat changed the title threading.Timer class: Continue periodical execution till action return True Feb 17, 2017
@slytomcat

slytomcat commented Feb 20, 2017

Copy link
Copy Markdown
Author

I have to reorganize my cloned repo so the CR have to be reissued.

@slytomcat slytomcat closed this Feb 20, 2017
@slytomcat slytomcat mentioned this pull request Feb 20, 2017
Closed
@slytomcat

slytomcat commented Feb 20, 2017

Copy link
Copy Markdown
Author

Reopened CR: #191

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.4-slp (Stackless python#121)
3d7d227
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
merge 3.3-slp (Stackless python#121)
a740da9
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
This was referenced Feb 11, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andrewnester andrewnester andrewnester left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slytomcat @andrewnester @the-knights-who-say-ni