{{ message }}
gh-121027: Make the functools.partial object a method descriptor#121089
Merged
serhiy-storchaka merged 2 commits intoJul 3, 2024
Merged
gh-121027: Make the functools.partial object a method descriptor#121089serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
5ecccee to
693fbc7
Compare
June 27, 2024 11:23
Contributor
|
This should have been labeled as "DO-NOT-MERGE" until #121086 was merged. There are conflicts anyway now. |
Sorry, something went wrong.
Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
693fbc7 to
d752505
Compare
June 27, 2024 11:56
rhettinger
approved these changes
Jun 30, 2024
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit ff5806c. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1226/builds/2167 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 130, in test_free_reference
self.assertIsNone(wr())
~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20002080170> is not None
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 130, in test_free_reference
self.assertIsNone(wr())
~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20006090090> is not None
|
Sorry, something went wrong.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
pythonGH-121089) Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
pythonGH-121089) Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
JelleZijlstra
added a commit
that referenced
this pull request
Sep 29, 2024
PR #121089 added an eager import for types.MethodType, but still left the existing hacks for lazily importing from types. We could also create MethodType internally in functools.py (e.g., by using `type(Placeholder.__repr__)`, but it feels not worth it at this point, so instead I unlazified all the usages of types in the module.
|
May I ask why this change was considered critical enough to not follow PEP 387? It is clearly backwards incompatible and is in fact breaking code, see lark-parser/lark#1480 . |
Sorry, something went wrong.
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Co-authored-by: d.grigonis dgrigonis@users.noreply.github.com
📚 Documentation preview 📚: https://cpython-previews--121089.org.readthedocs.build/