◐ Shell
reader mode source ↗
Skip to content

bpo-31904: Add posix module support for VxWorks RTOS#12118

Merged
vstinner merged 23 commits into
python:masterfrom
Wind-River:fix-issue-31904-os
May 21, 2019
Merged

bpo-31904: Add posix module support for VxWorks RTOS#12118
vstinner merged 23 commits into
python:masterfrom
Wind-River:fix-issue-31904-os

Conversation

@pxinwr

@pxinwr pxinwr commented Mar 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is the successive PR after #11968. This PR enables posix module support for VxWorks RTOS. VxWorks doesn't support fork()/exec(). Instead, we use rtpSpawn() to spawn new processes.
More and full support on modules for VxWorks will continuously be added by the coming PRs.
VxWorks is a product developed and owned by Wind River. For VxWorks introduction or more details, go to https://www.windriver.com/products/vxworks/
Wind River will have a dedicated engineering team to contribute to the support as maintainers.
We already have a working buildbot worker internally, but has not bound to master. We will check the process for the buildbot, then add it.

https://bugs.python.org/issue31904

@vstinner

vstinner commented Mar 1, 2019

Copy link
Copy Markdown
Member

@pablogsal @izbyshev @nanjekyejoannah: Would you min to review this change?

izbyshev
izbyshev reviewed Mar 2, 2019
View reviewed changes

@izbyshev izbyshev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Is there any plan to update documentation to reflect that some functions that are normally available on Unix are not actually available on VxWorks? With this patch, they are os.fork, os.exec* and os.spawn*p*.

@pablogsal pablogsal self-requested a review March 3, 2019 20:59
@pxinwr

pxinwr commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

@izbyshev

Is there any plan to update documentation to reflect that some functions that are normally available on Unix are not actually available on VxWorks? With this patch, they are os.fork, os.exec* and os.spawn*p*.

Have updated os.rst about this.

@pxinwr

pxinwr commented Mar 11, 2019

Copy link
Copy Markdown
Contributor Author

@izbyshev @pablogsal I've fixed all the issues reviewed out. Could you help to review again when available? Thanks a lot.

@yuesun1 yuesun1 mentioned this pull request Mar 14, 2019
Closed
@vstinner

vstinner commented Apr 16, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

See also #12319 " bpo-31904: Fix test_os failures for VxWorks RTOS #12319 ".

@pxinwr

pxinwr commented May 17, 2019

Copy link
Copy Markdown
Contributor Author

I've combined #12319 into this PR.

vstinner
vstinner reviewed May 17, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Your change seems reasonable, but I have a few comments.

@vstinner

vstinner commented May 17, 2019

Copy link
Copy Markdown
Member

I've combined #12319 into this PR.

Thanks, I like that :-)

24 hidden items Load more…
vstinner
vstinner reviewed May 17, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Your PR mostly LGTM, but I have a few more comments before being able to approve it.

@vstinner

vstinner commented May 21, 2019

Copy link
Copy Markdown
Member

LGTM except if the typo. Please fix the typo, so I can merge your PR ;-)

@vstinner vstinner merged commit f2d7ac7 into python:master May 21, 2019
@vstinner

vstinner commented May 21, 2019

Copy link
Copy Markdown
Member

Thanks @pxinwr! I know that this one was painful, but well, the os ("posix") module is where you can find most differences between operating systems.

@pxinwr pxinwr deleted the fix-issue-31904-os branch July 12, 2021 09:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

+1 more reviewer

@izbyshev izbyshev izbyshev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pxinwr @vstinner @izbyshev @the-knights-who-say-ni @bedevere-bot @yuesun1