{{ message }}
GH-119169: Slightly speed up os.walk(topdown=True)#121431
Merged
encukou merged 3 commits intoSep 3, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
When `os.walk()` traverses into subdirectories in top-down mode, call `os.path.join()` once to add a trailing slash, and use string concatenation thereafter to generate child paths.
eendebakpt
reviewed
Apr 17, 2025
Hide details
View details
encukou
merged commit
encukou
merged commit b19ad11
into
python:main
Sep 3, 2025
45 checks passed
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…121431) pythonGH-119186: Slightly speed up `os.walk(topdown=True)` When `os.walk()` traverses into subdirectories in top-down mode, call `os.path.join()` once to add a trailing slash, and use string concatenation thereafter to generate child paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
When
os.walk()traverses into subdirectories in top-down mode, callos.path.join()once to add a trailing slash, and use string concatenation thereafter to generate child paths.(this trick is already used in
os.fwalk())os.walk()#119169