◐ Shell
reader mode source ↗
Skip to content

gh-59022: Added tests for pkgutil.extend_path (#59022)#121673

Merged
encukou merged 2 commits into
python:mainfrom
beachmachine:fix-issue-59022
Jul 16, 2024
Merged

gh-59022: Added tests for pkgutil.extend_path (#59022)#121673
encukou merged 2 commits into
python:mainfrom
beachmachine:fix-issue-59022

Conversation

@beachmachine

@beachmachine beachmachine commented Jul 13, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This adds tests for the documented behaviour of pkgutil.extend_path regarding different argument types as well as for *.pkg files.

I took inspiration from the PR #12871 for the tests I've added. However, some of those tests did not seem to make sense to me, so I've ended up with the two test-cases in this PR.

@ghost

ghost commented Jul 13, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2024
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jul 13, 2024
@beachmachine
pythongh-59022: Added tests for pkgutil.extend_path (python#59022) …
982a647 
This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
@encukou

encukou commented Jul 14, 2024

Copy link
Copy Markdown
Member

Thanks! Just one more issue :)

For the future: please avoid force-pushing to CPython PRs; it makes them harder to review. Just add additional commits. The PR will be squashed when it's merged.

@beachmachine @encukou
pythongh-59022: Removed comment from test and rely on the documentati… …
814d8da 
…on only

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@beachmachine

beachmachine commented Jul 14, 2024

Copy link
Copy Markdown
Contributor Author

Thanks! Just one more issue :)

For the future: please avoid force-pushing to CPython PRs; it makes them harder to review. Just add additional commits. The PR will be squashed when it's merged.

Thanks for the hint. I will not use force-push for future CPython PRs.

Also, the comment in the test is removed now, so this PR is ready to be reviewed again.

@encukou

encukou commented Jul 16, 2024

Copy link
Copy Markdown
Member

Thank you!

@encukou encukou merged commit 8f25321 into python:main Jul 16, 2024
@encukou encukou added awaiting review needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 16, 2024

Copy link
Copy Markdown

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 16, 2024

Copy link
Copy Markdown

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
@beachmachine @miss-islington
pythongh-59022: Added tests for pkgutil.extend_path (pythonGH-59022) ( …
f761533 
pythonGH-121673)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
(cherry picked from commit 8f25321)

Co-authored-by: Andreas Stocker <andreas@stocker.co.it>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@beachmachine @estyxx
pythongh-59022: Added tests for pkgutil.extend_path (python#59022) (p… …
24120fd 
…ythonGH-121673)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
@beachmachine @miss-islington
pythongh-59022: Added tests for pkgutil.extend_path (pythonGH-59022) ( …
52eb80a 
pythonGH-121673)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
(cherry picked from commit 8f25321)

Co-authored-by: Andreas Stocker <andreas@stocker.co.it>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
@beachmachine @miss-islington
pythongh-59022: Added tests for pkgutil.extend_path (pythonGH-59022) ( …
464b398 
pythonGH-121673)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
(cherry picked from commit 8f25321)

Co-authored-by: Andreas Stocker <andreas@stocker.co.it>
@bedevere-app

bedevere-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

GH-121950 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 18, 2024
@bedevere-app

bedevere-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

GH-121951 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
encukou pushed a commit that referenced this pull request Jul 19, 2024
@miss-islington @beachmachine
[3.13] gh-59022: Added tests for pkgutil.extend_path (GH-121673) (G… …
963e97d 
…H-121951)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
(cherry picked from commit 8f25321)

Co-authored-by: Andreas Stocker <andreas@stocker.co.it>
encukou pushed a commit that referenced this pull request Jul 19, 2024
@miss-islington @beachmachine
[3.12] gh-59022: Added tests for pkgutil.extend_path (GH-121673) (G… …
3f72821 
…H-121950)

This adds tests for the documented behaviour of `pkgutil.extend_path`
regarding different argument types as well as for `*.pkg` files.
(cherry picked from commit 8f25321)

Co-authored-by: Andreas Stocker <andreas@stocker.co.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting review tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beachmachine @encukou