◐ Shell
reader mode source ↗
Skip to content

[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941)#12177

Merged
vstinner merged 4 commits into
python:2.7from
matrixise:bpo-36019-2.7
Mar 5, 2019
Merged

[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941)#12177
vstinner merged 4 commits into
python:2.7from
matrixise:bpo-36019-2.7

Conversation

@matrixise

@matrixise matrixise commented Mar 5, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@matrixise matrixise changed the title [2.7]: bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) Mar 5, 2019
vstinner
vstinner requested changes Mar 5, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

test_urllib2net.py: More tests still use "http://www.example.com/":

  • CloseSocketTest.test_close()
  • test_fileno() and test_custom_headers() of OtherNetworkTests.
  • TimeoutTest

@bedevere-bot

bedevere-bot commented Mar 5, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise

matrixise commented Mar 5, 2019

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Mar 5, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Mar 5, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I blocked access to example.com from my laptop using:
#11941 (review)

Without the test, test_urllib2net fails. With the change, test_urllib2net pass. Command "./python -m test -u all test_urllib2net".

I also ran "./python -m test -j0 -u all -r" with the change: SUCCESS.

@vstinner vstinner merged commit 84772e0 into python:2.7 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matrixise @bedevere-bot @vstinner @the-knights-who-say-ni