{{ message }}
CI: Fix using check_source flags as bool#121848
Merged
hugovk merged 2 commits intoJul 16, 2024
Merged
Conversation
Member
Sorry, something went wrong.
hugovk
reviewed
Jul 16, 2024
webknjaz
force-pushed
the
bugfixes/gha-job-conditional-flags
branch
from
911e78f to
84f6498
Compare
July 16, 2024 12:15
hugovk
reviewed
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
This updates it to avoid referencing to `no-GIL` in favor of the official term `free-threading`.
webknjaz
force-pushed
the
bugfixes/gha-job-conditional-flags
branch
from
84f6498 to
d42c6f6
Compare
July 16, 2024 12:23
hugovk
approved these changes
Jul 16, 2024
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Member
|
Yeah, let's test to confirm it works as expected by updating #121831 after this has merged. |
Sorry, something went wrong.
hugovk
added
needs backport to 3.12
only security fixes
needs backport to 3.13
bugs and security fixes
labels
Jul 16, 2024
|
Sorry, @webknjaz and @hugovk, I could not cleanly backport this to |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
1 similar comment
hugovk
pushed a commit
that referenced
this pull request
Jul 16, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
hugovk
pushed a commit
that referenced
this pull request
Jul 16, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds
falsefallbacks to all such outputs.This allows feeding them to
fromJSON()without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [1]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view asWaiting for pending jobsand in the${{ needs }}context, they would have aresult: failureentry [2].This should help make PRs like #121831 mergeable again.