◐ Shell
reader mode source ↗
Skip to content

gh-122170: Handle ValueError raised by os.stat in linecache#122176

Merged
serhiy-storchaka merged 8 commits into
python:mainfrom
picnixz:fix-linecache-valueerror
Jul 27, 2024
Merged

gh-122170: Handle ValueError raised by os.stat in linecache#122176
serhiy-storchaka merged 8 commits into
python:mainfrom
picnixz:fix-linecache-valueerror

Conversation

@picnixz

@picnixz picnixz commented Jul 23, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jul 23, 2024
Closed
@picnixz picnixz changed the title gh-122170: Handle long filenames on Windows platforms in linecache Jul 24, 2024
@picnixz picnixz mentioned this pull request Jul 24, 2024
Closed
@picnixz picnixz requested a review from serhiy-storchaka July 24, 2024 14:24
@picnixz picnixz added the Standard Library Python modules in the Lib/ directory label Jul 25, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jul 27, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) July 27, 2024 10:02
@serhiy-storchaka serhiy-storchaka merged commit 7a6d4cc into python:main Jul 27, 2024
@picnixz picnixz deleted the fix-linecache-valueerror branch July 27, 2024 10:18
@picnixz

picnixz commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Should I backport this one to 3.12 and 3.13? (I would say yes)

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p… …
84f35b9 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

GH-122348 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
@picnixz @miss-islington
pythongh-122170: Handle ValueError raised by os.stat() in linecache (p… …
e99304b 
…ythonGH-122176)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jul 27, 2024

Copy link
Copy Markdown

GH-122349 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 27, 2024
@serhiy-storchaka

serhiy-storchaka commented Jul 27, 2024

Copy link
Copy Markdown
Member

Yes, this can be considered as a bug fix, although very minor.

serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.12] gh-122170: Handle ValueError raised by os.stat() in linecache (G… …
2e37d67 
…H-122176) (GH-122349)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jul 27, 2024
@miss-islington @picnixz
[3.13] gh-122170: Handle ValueError raised by os.stat() in linecache (G… …
3648a94 
…H-122176) (GH-122348)

(cherry picked from commit 7a6d4cc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @serhiy-storchaka