{{ message }}
bpo-33608: Fix the Py_atomic_* macros.#12240
Merged
ericsnowcurrently merged 1 commit intoMar 8, 2019
Merged
Conversation
Member
Sorry, something went wrong.
|
@ericsnowcurrently: Please replace |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit 2aab5d3. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/99/builds/2269 Click to see traceback logsTraceback (most recent call last):
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 242, in wrapped
meth(self)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 269, in test_with_statement
with self.NNTP_CLASS(self.NNTP_HOST, timeout=TIMEOUT, usenetrc=False) as server:
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 1077, in __init__
self.sock = _encrypt_on(self.sock, ssl_context, host)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 292, in _encrypt_on
return context.wrap_socket(sock, server_hostname=hostname)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/ssl.py", line 405, in wrap_socket
return self.sslsocket_class._create(
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/ssl.py", line 853, in _create
self.do_handshake()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/ssl.py", line 1117, in do_handshake
self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1055)
----------------------------------------------------------------------
Ran 106 tests in 248.592s
FAILED (errors=1, skipped=4)
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 242, in wrapped
meth(self)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 269, in test_with_statement
with self.NNTP_CLASS(self.NNTP_HOST, timeout=TIMEOUT, usenetrc=False) as server:
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 1047, in __init__
_NNTPBase.__init__(self, file, host,
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 334, in __init__
self.getcapabilities()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 390, in getcapabilities
resp, caps = self.capabilities()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 558, in capabilities
resp, lines = self._longcmdstring("CAPABILITIES")
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 525, in _longcmdstring
resp, list = self._getlongresp(file)
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 476, in _getlongresp
resp = self._getresp()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 449, in _getresp
resp = self._getline()
File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 437, in _getline
if not line: raise EOFError
EOFError
----------------------------------------------------------------------
Ran 106 tests in 349.352s
FAILED (errors=1, skipped=5)
|
Sorry, something went wrong.
Member
Author
|
I'm pretty sure this isn't due to this commit. |
Sorry, something went wrong.
paulmon
reviewed
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The macros currently work because our usage happens to parse correctly. I ran into the problem while working on a PR (for bpo-33608) that involves a pointer indirection.
Note that this was part of a PR (gh-12062) that already landed and had to be reverted. This is the part that was unrelated to the need to revert.
https://bugs.python.org/issue33608