gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded#122436
Conversation
|
I won't be able to review this for at least a couple of weeks. |
Sorry, something went wrong.
…9 return False on error
|
My last push produced an error in a thread sanitizer check from code completely unrelated to mine , so I thought I'd try "fixing" the error by rebasing my branch to the latest master in hope that someone else already fixed the issue, and that resulted in the massive inclusion of all commits between the master my branch was originally based on and the latest master. I tried to undo my rebase by force-pushing my last commit to the branch, but it still results in the code owners of all unrelated commits being tagged as reviewers for this PR by GitHub. Sorry about that. |
Sorry, something went wrong.
|
This is why merge is better than rebase when updating PR. |
Sorry, something went wrong.
Lesson learned. Thanks. |
Sorry, something went wrong.
|
I've restored the previous reviewers list. |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
|
Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to |
Sorry, something went wrong.
|
Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to |
Sorry, something went wrong.
datetime.*.strftime()year padding behavior across%y,%Y,%Fand%C#122272