{{ message }}
gh-122681: merge m_atan2() and c_atan2() helper functions#122682
Merged
vstinner merged 7 commits intoAug 6, 2024
Merged
Conversation
Member
Sorry, something went wrong.
vstinner
reviewed
Aug 5, 2024
vstinner
approved these changes
Aug 6, 2024
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Member
|
I merged the main branch into this PR to retrieve the Hypothesis workaround (pin attrs version). |
Sorry, something went wrong.
Member
|
Merged. Thank you. |
Sorry, something went wrong.
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
For reviewers: as it mentioned in the issue, I think it worth to try removing these workarounds. Most cmath's functions are using libm's atan2() and this don't poses any problems. If that does make sense, here is a draft pr to test this: #122715.