{{ message }}
gh-117139: Fix a few _PyStackRef related bugs#122831
Merged
colesbury merged 1 commit intoAug 12, 2024
Merged
Conversation
Contributor
Sorry, something went wrong.
BUILD_SET should use a borrow instead of a steal. The cleanup in _DO_CALL CONVERSION_FAILED was incorrect. Co-authored-by: Ken Jin <kenjin@python.org>
DinoV
approved these changes
Aug 12, 2024
DinoV
left a comment
DinoV
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
`BUILD_SET` should use a borrow instead of a steal. The cleanup in `_DO_CALL` `CONVERSION_FAILED` was incorrect. Co-authored-by: Ken Jin <kenjin@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
BUILD_SETshould use a borrow instead of a steal. The cleanup in_DO_CALL'sCONVERSION_FAILEDwas incorrect.