◐ Shell
reader mode source ↗
Skip to content

gh-89683: add tests for deepcopy on frozen dataclasses#123098

Merged
ericvsmith merged 3 commits into
python:mainfrom
picnixz:89683-frozen-dataclass-deep-copy-with-slots
Sep 26, 2024
Merged

gh-89683: add tests for deepcopy on frozen dataclasses#123098
ericvsmith merged 3 commits into
python:mainfrom
picnixz:89683-frozen-dataclass-deep-copy-with-slots

Conversation

@picnixz

@picnixz picnixz commented Aug 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Note that I did not change the existing behaviour. Should we, in the case the user defines their own slot, automatically add __{get,set}state__ methods if they are not provided?

@picnixz picnixz requested a review from ericvsmith as a code owner August 17, 2024 11:12
@bedevere-app bedevere-app Bot mentioned this pull request Aug 17, 2024
Closed
@picnixz picnixz changed the title gh-89783: add tests for deepcopy on frozen dataclasses Aug 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 17, 2024
Closed
@ericvsmith ericvsmith added 3.12 3.13 bugs and security fixes labels Sep 26, 2024
@ericvsmith ericvsmith self-assigned this Sep 26, 2024
@ericvsmith ericvsmith enabled auto-merge (squash) September 26, 2024 20:44
@ericvsmith ericvsmith merged commit 5e7eba0 into python:main Sep 26, 2024
@ericvsmith ericvsmith added only security fixes needs backport to 3.13 and removed 3.12 only security fixes 3.13 bugs and security fixes labels Sep 26, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

Sorry, @picnixz and @ericvsmith, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5e7eba09bcdafe361b491b3f8cf30d7dd2df0a78 3.13

@miss-islington-app

miss-islington-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

Sorry, @picnixz and @ericvsmith, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5e7eba09bcdafe361b491b3f8cf30d7dd2df0a78 3.12

@picnixz picnixz deleted the 89683-frozen-dataclass-deep-copy-with-slots branch September 26, 2024 21:27
@picnixz

picnixz commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

Erf, backports failed. I'll take care of them now.

@ericvsmith

ericvsmith commented Sep 27, 2024

Copy link
Copy Markdown
Member

@picnixz : Thanks!

picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho… …
7f4762a 
…ngh-123098)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124678 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho… …
02ce930 
…ngh-123098)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

# Conflicts:
#	Lib/test/test_dataclasses/__init__.py
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho… …
f4b65bf 
…ngh-123098)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124679 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 27, 2024
@picnixz

picnixz commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

Backports are ready (I really hate making backports manually because cherry_picker tells me I'm outside a CPython repository).

@ericvsmith

ericvsmith commented Sep 27, 2024

Copy link
Copy Markdown
Member

You're better than me: I tried using cherry_picker and failed. Thanks for the backports.

ericvsmith added a commit that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
[3.12] gh-89683: add tests for deepcopy on frozen dataclasses (GH-1… …
373036a 
…23098) (gh-124679)

gh-89683: add tests for `deepcopy` on frozen dataclasses (gh-123098)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@picnixz @ericvsmith
[3.13] gh-89683: add tests for deepcopy on frozen dataclasses (GH-1… …
6b847be 
…23098) (#124678)

* gh-89683: add tests for `deepcopy` on frozen dataclasses (gh-123098)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@ericvsmith ericvsmith

Labels

skip news topic-dataclasses

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @ericvsmith